From 58cefed29c3bd4ab419a8026b96f9fba8b9e86c7 Mon Sep 17 00:00:00 2001 From: Jon Kunkee Date: Tue, 19 Feb 2019 19:02:02 -0800 Subject: [PATCH] snapshot: add source line stubs for ARM64 Windows When stubbing out source line information emission for Windows, the ARM64 Windows branch was missed. This change copies the x86/x64 stubs as appropriate. Bug: chromium:893460,v8:8870 R=jgruber@chromium.org Bug: chromium:893460,v8:8870 Change-Id: I1416b602a4f96a68c37fdeeb816ce1ce33b12407 Reviewed-on: https://chromium-review.googlesource.com/c/1453637 Commit-Queue: Jakob Gruber Reviewed-by: Jakob Gruber Reviewed-by: Michael Stanton Cr-Commit-Position: refs/heads/master@{#59817} --- src/snapshot/embedded-file-writer.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/snapshot/embedded-file-writer.cc b/src/snapshot/embedded-file-writer.cc index c32f5f65b7..cfeb6a45ff 100644 --- a/src/snapshot/embedded-file-writer.cc +++ b/src/snapshot/embedded-file-writer.cc @@ -373,7 +373,7 @@ void PlatformDependentEmbeddedFileWriter::DeclareLabel(const char* name) { void PlatformDependentEmbeddedFileWriter::SourceInfo(int fileid, int line) { // TODO(mvstanton): output source information for MSVC. - // It's syntax is #line "" + // Its syntax is #line "" } void PlatformDependentEmbeddedFileWriter::DeclareFunctionBegin( @@ -477,6 +477,11 @@ void PlatformDependentEmbeddedFileWriter::DeclareLabel(const char* name) { fprintf(fp_, "%s%s\n", SYMBOL_PREFIX, name); } +void PlatformDependentEmbeddedFileWriter::SourceInfo(int fileid, int line) { + // TODO(mvstanton): output source information for MSVC. + // Its syntax is #line "" +} + void PlatformDependentEmbeddedFileWriter::DeclareFunctionBegin( const char* name) { fprintf(fp_, "%s%s FUNCTION\n", SYMBOL_PREFIX, name); @@ -492,6 +497,9 @@ int PlatformDependentEmbeddedFileWriter::HexLiteral(uint64_t value) { void PlatformDependentEmbeddedFileWriter::FilePrologue() {} +void PlatformDependentEmbeddedFileWriter::DeclareExternalFilename( + int fileid, const char* filename) {} + void PlatformDependentEmbeddedFileWriter::FileEpilogue() { fprintf(fp_, " END\n"); }