From 58fea9c1e2f0ebf9b804c7855800936b3906a3fa Mon Sep 17 00:00:00 2001 From: Maciej Goszczycki Date: Tue, 14 May 2019 18:27:21 +0100 Subject: [PATCH] [heap] Enable read-only heap sharing for lite-mode Bug: v8:7464 Change-Id: I50de5f19f3303625a492faad5da378e2f0d3ed3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602699 Reviewed-by: Dan Elphick Commit-Queue: Maciej Goszczycki Cr-Commit-Position: refs/heads/master@{#61514} --- BUILD.gn | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 384a94766b..319f44ea38 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -186,7 +186,8 @@ declare_args() { v8_check_header_includes = false # Enable sharing read-only space across isolates. - v8_enable_shared_ro_heap = false + # Sets -DV8_SHARED_RO_HEAP. + v8_enable_shared_ro_heap = "" } # We reuse the snapshot toolchain for building torque and other generators to @@ -224,6 +225,9 @@ if (v8_check_microtasks_scopes_consistency == "") { if (v8_enable_snapshot_native_code_counters == "") { v8_enable_snapshot_native_code_counters = v8_enable_debugging_features } +if (v8_enable_shared_ro_heap == "") { + v8_enable_shared_ro_heap = v8_enable_lite_mode +} assert(v8_current_cpu != "x86" || !v8_untrusted_code_mitigations, "Untrusted code mitigations are unsupported on ia32") @@ -233,9 +237,6 @@ assert(!v8_enable_lite_mode || v8_enable_embedded_builtins, assert(!v8_enable_lite_mode || v8_use_snapshot, "Lite mode requires a snapshot build") -assert(v8_use_snapshot || !v8_enable_shared_ro_heap, - "Nosnapshot builds are not supported with shared read-only heap enabled") - assert( !v8_enable_pointer_compression || !v8_enable_shared_ro_heap, "Pointer compression is not supported with shared read-only heap enabled")