AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove obsolete specialization zone.

Browse Source 
R=clemensh@chromium.org

Change-Id: Iac827a4fc82f9b810af9d67c4aa5757925edc3c5
Reviewed-on: https://chromium-review.googlesource.com/997742
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52399}
This commit is contained in:
Michael Starzinger 2018-04-05 15:54:26 +02:00 committed by Commit Bot
parent 0340874be4
commit 595f14281f
5 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wasm/module-compiler.cc
View File

@ -15,6 +15,7 @@
#include "src/code-stubs.h"
#include "src/compiler/wasm-compiler.h"
#include "src/counters.h"
#include "src/identity-map.h"
#include "src/property-descriptor.h"
#include "src/trap-handler/trap-handler.h"
#include "src/wasm/compilation-manager.h"
@ -578,8 +579,7 @@ const wasm::WasmCode* LazyCompilationOrchestrator::CompileFunction(
CHECK(!thrower.error());
// Now specialize the generated code for this instance.
Zone specialization_zone(isolate->allocator(), ZONE_NAME);
CodeSpecialization code_specialization(isolate, &specialization_zone);
CodeSpecialization code_specialization;
code_specialization.RelocateDirectCalls(compiled_module->GetNativeModule());
code_specialization.ApplyToWasmCode(wasm_code, SKIP_ICACHE_FLUSH);
int64_t func_size =
@ -1641,8 +1641,7 @@ MaybeHandle<WasmInstanceObject> InstanceBuilder::Build() {
//--------------------------------------------------------------------------
// Create the WebAssembly.Instance object.
//--------------------------------------------------------------------------
Zone instantiation_zone(isolate_->allocator(), ZONE_NAME);
CodeSpecialization code_specialization(isolate_, &instantiation_zone);
CodeSpecialization code_specialization;
Handle<WasmInstanceObject> instance =
WasmInstanceObject::New(isolate_, compiled_module_);

2
src/wasm/wasm-code-specialization.cc
View File

@ -59,7 +59,7 @@ class PatchDirectCallsHelper {
} // namespace
CodeSpecialization::CodeSpecialization(Isolate* isolate, Zone* zone) {}
CodeSpecialization::CodeSpecialization() {}
CodeSpecialization::~CodeSpecialization() {}

3
src/wasm/wasm-code-specialization.h
View File

@ -6,7 +6,6 @@
#define V8_WASM_WASM_CODE_SPECIALIZATION_H_
#include "src/assembler.h"
#include "src/identity-map.h"
#include "src/wasm/decoder.h"
#include "src/wasm/wasm-objects.h"
@ -25,7 +24,7 @@ uint32_t ExtractDirectCallIndex(wasm::Decoder& decoder, const byte* pc);
// Patch* methods, then apply all changes in one step using the Apply* methods.
class CodeSpecialization {
public:
CodeSpecialization(Isolate*, Zone*);
CodeSpecialization();
~CodeSpecialization();
// Update WasmContext references.

3
src/wasm/wasm-objects.cc
View File

@ -1346,8 +1346,7 @@ void WasmCompiledModule::Reset(Isolate* isolate,
// Patch code to update memory references, global references, and function
// table references.
Zone specialization_zone(isolate->allocator(), ZONE_NAME);
wasm::CodeSpecialization code_specialization(isolate, &specialization_zone);
wasm::CodeSpecialization code_specialization;
if (compiled_module->has_lazy_compile_data()) {
for (int i = 0, e = compiled_module->lazy_compile_data()->length(); i < e;

3
test/cctest/wasm/wasm-run-utils.h
View File

@ -204,8 +204,7 @@ class TestingModuleBuilder {
Address globals_start() { return reinterpret_cast<Address>(globals_data_); }
void Link() {
if (!linked_) {
Zone specialization_zone(isolate()->allocator(), ZONE_NAME);
CodeSpecialization code_specialization(isolate(), &specialization_zone);
CodeSpecialization code_specialization;
code_specialization.RelocateDirectCalls(native_module_);
code_specialization.ApplyToWholeModule(native_module_);
linked_ = true;