AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Simplify call to {AllocateHeapNumber} builtin.

Browse Source 
R=clemensh@chromium.org

Change-Id: Iddce87713b09450bf069a12f0aa7aa55c7f131e1
Reviewed-on: https://chromium-review.googlesource.com/1097120
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53685}
This commit is contained in:
Michael Starzinger 2018-06-12 15:06:54 +02:00 committed by Commit Bot
parent 78c2e1a57b
commit 59c396a678
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/compiler/wasm-compiler.cc
View File

@ -4009,32 +4009,25 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
Node* BuildAllocateHeapNumberWithValue(Node* value, Node* control) {
MachineOperatorBuilder* machine = mcgraph()->machine();
CommonOperatorBuilder* common = mcgraph()->common();
// The AllocateHeapNumber builtin does not use the js_context, so we can
// safely pass in Smi zero here.
Callable callable =
Builtins::CallableFor(isolate_, Builtins::kAllocateHeapNumber);
Node* target = jsgraph()->HeapConstant(callable.code());
Node* js_context = jsgraph()->NoContextConstant();
Node* begin_region = graph()->NewNode(
common->BeginRegion(RegionObservability::kNotObservable), *effect_);
if (!allocate_heap_number_operator_.is_set()) {
auto call_descriptor = Linkage::GetStubCallDescriptor(
isolate_, mcgraph()->zone(), callable.descriptor(), 0,
CallDescriptor::kNoFlags, Operator::kNoThrow);
CallDescriptor::kNoFlags, Operator::kNoThrow,
MachineType::AnyTagged(), 1, Linkage::kNoContext);
allocate_heap_number_operator_.set(common->Call(call_descriptor));
}
Node* heap_number =
graph()->NewNode(allocate_heap_number_operator_.get(), target,
js_context, begin_region, control);
Node* heap_number = graph()->NewNode(allocate_heap_number_operator_.get(),
target, *effect_, control);
Node* store =
graph()->NewNode(machine->Store(StoreRepresentation(
MachineRepresentation::kFloat64, kNoWriteBarrier)),
heap_number, BuildHeapNumberValueIndexConstant(),
value, heap_number, control);
Node* finish_region =
graph()->NewNode(common->FinishRegion(), heap_number, store);
*effect_ = finish_region;
return finish_region;
*effect_ = store;
return heap_number;
}
Node* BuildChangeSmiToFloat64(Node* value) {
@ -4273,7 +4266,6 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
Node* num = BuildJavaScriptToNumber(node, js_context);
// Change representation.
SimplifiedOperatorBuilder simplified(mcgraph()->zone());
num = BuildChangeTaggedToFloat64(num);
switch (type) {