diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index ddc9ff81f7..3615cba914 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -278,8 +278,6 @@ DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs) // Features that are shipping (turned on by default, but internal flag remains). #define HARMONY_SHIPPING_BASE(V) \ - V(harmony_namespace_exports, \ - "harmony namespace exports (export * as foo from 'bar')") \ V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \ V(harmony_atomics, "harmony atomics") \ V(harmony_promise_all_settled, "harmony Promise.allSettled") \ diff --git a/src/init/bootstrapper.cc b/src/init/bootstrapper.cc index bfe2166aa5..b3d1b54f30 100644 --- a/src/init/bootstrapper.cc +++ b/src/init/bootstrapper.cc @@ -4126,7 +4126,6 @@ void Genesis::InitializeCallSiteBuiltins() { #define EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(id) \ void Genesis::InitializeGlobal_##id() {} -EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_namespace_exports) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_private_methods) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexp_sequence) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_top_level_await) diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc index bbb5c64594..48b087768b 100644 --- a/src/parsing/parser.cc +++ b/src/parsing/parser.cc @@ -1465,8 +1465,7 @@ void Parser::ParseExportStar() { int pos = position(); Consume(Token::MUL); - if (!FLAG_harmony_namespace_exports || - !PeekContextualKeyword(ast_value_factory()->as_string())) { + if (!PeekContextualKeyword(ast_value_factory()->as_string())) { // 'export' '*' 'from' ModuleSpecifier ';' Scanner::Location loc = scanner()->location(); ExpectContextualKeyword(ast_value_factory()->from_string()); @@ -1478,7 +1477,6 @@ void Parser::ParseExportStar() { specifier_loc, zone()); return; } - if (!FLAG_harmony_namespace_exports) return; // 'export' '*' 'as' IdentifierName 'from' ModuleSpecifier ';' // diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc index ca0315a16c..a49b5b9255 100644 --- a/test/cctest/test-parsing.cc +++ b/test/cctest/test-parsing.cc @@ -7626,7 +7626,6 @@ TEST(NamespaceExportParsing) { }; // clang-format on - i::FLAG_harmony_namespace_exports = true; i::Isolate* isolate = CcTest::i_isolate(); i::Factory* factory = isolate->factory(); diff --git a/test/message/fail/modules-duplicate-export5.mjs b/test/message/fail/modules-duplicate-export5.mjs index e936914eab..5d4ad3415e 100644 --- a/test/message/fail/modules-duplicate-export5.mjs +++ b/test/message/fail/modules-duplicate-export5.mjs @@ -2,7 +2,5 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-namespace-exports - export let foo = 42; export * as foo from "./doesnt-even-matter.mjs"; diff --git a/test/message/fail/modules-duplicate-export5.out b/test/message/fail/modules-duplicate-export5.out index 2efaef10c4..7d62b69dc0 100644 --- a/test/message/fail/modules-duplicate-export5.out +++ b/test/message/fail/modules-duplicate-export5.out @@ -1,4 +1,4 @@ -*%(basename)s:8: SyntaxError: Duplicate export of 'foo' +*%(basename)s:6: SyntaxError: Duplicate export of 'foo' export * as foo from "./doesnt-even-matter.mjs"; ^^^ SyntaxError: Duplicate export of 'foo' diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py index c88396c3f6..6f375fbf2f 100644 --- a/test/test262/testcfg.py +++ b/test/test262/testcfg.py @@ -49,7 +49,6 @@ FEATURE_FLAGS = { 'Intl.DateTimeFormat-quarter': '--harmony-intl-dateformat-quarter', 'String.prototype.replaceAll': '--harmony_string_replaceall', 'Symbol.prototype.description': '--harmony-symbol-description', - 'export-star-as-namespace-from-module': '--harmony-namespace-exports', 'Promise.allSettled': '--harmony-promise-all-settled', 'FinalizationRegistry': '--harmony-weak-refs-with-cleanup-some', 'WeakRef': '--harmony-weak-refs-with-cleanup-some',