AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove unused {UseLazyStubs}

Browse Source 
Remove unused function {UseLazyStubs}. Lazy compile stubs are now set on
a per function basis. This made the function {UseLazyStubs} redundant.

Change-Id: I8e715d6a9774c39841219c04c42364fc2e964569
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588473
Commit-Queue: Frederik Gossen <frgossen@google.com>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61124}
This commit is contained in:
Frederik Gossen 2019-04-30 16:29:56 +02:00 committed by Commit Bot
parent 18c29ab939
commit 5a0f0ebfad
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wasm/wasm-code-manager.cc
View File

@ -500,14 +500,6 @@ WasmCode* NativeModule::AddCodeForTesting(Handle<Code> code) {
return AddAndPublishAnonymousCode(code, WasmCode::kFunction); return AddAndPublishAnonymousCode(code, WasmCode::kFunction);
} }
void NativeModule::UseLazyStubs() {
uint32_t start = module_->num_imported_functions;
uint32_t end = start + module_->num_declared_functions;
for (uint32_t func_index = start; func_index < end; func_index++) {
UseLazyStub(func_index);
}
}
void NativeModule::UseLazyStub(uint32_t func_index) { void NativeModule::UseLazyStub(uint32_t func_index) {
DCHECK_LE(module_->num_imported_functions, func_index); DCHECK_LE(module_->num_imported_functions, func_index);
DCHECK_LT(func_index, DCHECK_LT(func_index,

8
src/wasm/wasm-code-manager.h
View File

@ -305,11 +305,9 @@ class V8_EXPORT_PRIVATE NativeModule final {
// Adds anonymous code for testing purposes. // Adds anonymous code for testing purposes.
WasmCode* AddCodeForTesting(Handle<Code> code); WasmCode* AddCodeForTesting(Handle<Code> code);
// Use this to setup lazy compilation for the entire module ({UseLazyStubs}) // Use {UseLazyStub} to setup lazy compilation per function. It will use the
// or for individual functions ({UseLazyStub}). It will use the existing // existing {WasmCode::kWasmCompileLazy} runtime stub and populate the jump
// {WasmCode::kWasmCompileLazy} runtime stub and populate the jump table with // table with trampolines accordingly.
// trampolines to that runtime stub.
void UseLazyStubs();
void UseLazyStub(uint32_t func_index); void UseLazyStub(uint32_t func_index);
// Initializes all runtime stubs by setting up entry addresses in the runtime // Initializes all runtime stubs by setting up entry addresses in the runtime