Generalized Stephen's patch from http://codereview.chromium.org/7044100/ and
added a few test cases. Review URL: http://codereview.chromium.org/7212006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8323 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
2fe5afedf3
commit
5a547ac413
@ -2545,18 +2545,26 @@ Expression* Parser::ParseUnaryExpression(bool* ok) {
|
||||
int position = scanner().location().beg_pos;
|
||||
Expression* expression = ParseUnaryExpression(CHECK_OK);
|
||||
|
||||
// Compute some expressions involving only number literals.
|
||||
if (expression != NULL && expression->AsLiteral() &&
|
||||
expression->AsLiteral()->handle()->IsNumber()) {
|
||||
double value = expression->AsLiteral()->handle()->Number();
|
||||
switch (op) {
|
||||
case Token::ADD:
|
||||
return expression;
|
||||
case Token::SUB:
|
||||
return NewNumberLiteral(-value);
|
||||
case Token::BIT_NOT:
|
||||
return NewNumberLiteral(~DoubleToInt32(value));
|
||||
default: break;
|
||||
if (expression != NULL && (expression->AsLiteral() != NULL)) {
|
||||
Handle<Object> literal = expression->AsLiteral()->handle();
|
||||
if (op == Token::NOT) {
|
||||
// Convert the literal to a boolean condition and negate it.
|
||||
bool condition = literal->ToBoolean()->IsTrue();
|
||||
Handle<Object> result(isolate()->heap()->ToBoolean(!condition));
|
||||
return new(zone()) Literal(result);
|
||||
} else if (literal->IsNumber()) {
|
||||
// Compute some expressions involving only number literals.
|
||||
double value = literal->Number();
|
||||
switch (op) {
|
||||
case Token::ADD:
|
||||
return expression;
|
||||
case Token::SUB:
|
||||
return NewNumberLiteral(-value);
|
||||
case Token::BIT_NOT:
|
||||
return NewNumberLiteral(~DoubleToInt32(value));
|
||||
default:
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
59
test/mjsunit/not.js
Normal file
59
test/mjsunit/not.js
Normal file
@ -0,0 +1,59 @@
|
||||
// Copyright 2011 the V8 project authors. All rights reserved.
|
||||
// Redistribution and use in source and binary forms, with or without
|
||||
// modification, are permitted provided that the following conditions are
|
||||
// met:
|
||||
//
|
||||
// * Redistributions of source code must retain the above copyright
|
||||
// notice, this list of conditions and the following disclaimer.
|
||||
// * Redistributions in binary form must reproduce the above
|
||||
// copyright notice, this list of conditions and the following
|
||||
// disclaimer in the documentation and/or other materials provided
|
||||
// with the distribution.
|
||||
// * Neither the name of Google Inc. nor the names of its
|
||||
// contributors may be used to endorse or promote products derived
|
||||
// from this software without specific prior written permission.
|
||||
//
|
||||
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
||||
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
||||
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
||||
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
||||
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
||||
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
||||
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
||||
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
||||
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
|
||||
function testNot(x) {
|
||||
// The VM constant folds so we use that to check the result.
|
||||
var expected = eval("!(" + x + ")");
|
||||
var actual = !x;
|
||||
assertEquals(expected, actual, "x: " + x);
|
||||
}
|
||||
|
||||
testNot(0);
|
||||
testNot(1);
|
||||
testNot(-1);
|
||||
testNot(-0);
|
||||
|
||||
testNot(NaN);
|
||||
testNot(Infinity);
|
||||
testNot(-Infinity);
|
||||
|
||||
testNot(true);
|
||||
testNot(false);
|
||||
|
||||
assertTrue(!"");
|
||||
assertFalse(!"foo");
|
||||
|
||||
assertFalse(![]);
|
||||
assertFalse(![1]);
|
||||
assertFalse(![1,2]);
|
||||
|
||||
assertFalse(!{});
|
||||
assertFalse(!{foo:1});
|
||||
assertFalse(!{foo:1,bar:2});
|
||||
|
||||
assertFalse(!!0);
|
||||
assertTrue(!!1);
|
Loading…
Reference in New Issue
Block a user