AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[presubmit] Extend regular expression for V8_NOEXCEPT

Browse Source 
We were missing a few declarations, especially fully-qualified
declarations in cc files like here: https://crrev.com/c/1396459

R=mlippautz@chromium.org

Bug: v8:8616
No-Try: true
Change-Id: Iff93f1cd4fde18ac7fc8391e459e6bdcb4eb8f9b
Reviewed-on: https://chromium-review.googlesource.com/c/1397706
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58585}
This commit is contained in:
Clemens Hammacher 2019-01-07 13:35:49 +01:00 committed by Commit Bot
parent 62302d6ca4
commit 5a5606bec3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PRESUBMIT.py
View File

@ -464,13 +464,13 @@ def _CheckNoexceptAnnotations(input_api, output_api):
# matches any class name.
class_name = r'\b([A-Z][A-Za-z0-9_]*)(?:::\1)?'
class_name = r'\b([A-Z][A-Za-z0-9_:]*)(?:::\1)?'
# initial class name is potentially followed by this to declare an assignment
# operator.
potential_assignment = r'(?:&\s+operator=)?\s*'
potential_assignment = r'(?:&\s+(?:\1::)?operator=)?\s*'
# matches an argument list that contains only a reference to a class named
# like the first capture group, potentially const.
single_class_ref_arg = r'\((?:const\s+)?\1(?:::\1)?&&?[^,;)]*\)'
single_class_ref_arg = r'\(\s*(?:const\s+)?\1(?:::\1)?&&?[^,;)]*\)'
# matches anything but a sequence of whitespaces followed by either
# V8_NOEXCEPT or "= delete".
not_followed_by_noexcept = r'(?!\s+(?:V8_NOEXCEPT|=\s+delete)\b)'