AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Sidestep the interpreter for generator literals.

Browse Source 
This is because compiler.cc is awesome. There are cases where we do not
yet have a SharedFunctionInfo that can tell us whether we are compiling
a generator function, we query the FunctionLiteral instead.

R=rmcilroy@chromium.org
BUG=v8:4681
LOG=n

Review URL: https://codereview.chromium.org/1780193002

Cr-Commit-Position: refs/heads/master@{#34677}
This commit is contained in:
mstarzinger 2016-03-10 06:34:46 -08:00 committed by Commit bot
parent 62bf607f79
commit 5bd307fa72
3 changed files with 3 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler.cc
View File

@ -793,7 +793,8 @@ static bool UseIgnition(CompilationInfo* info) {
}
// TODO(4681): Generators are not yet supported.
if (info->has_shared_info() && info->shared_info()->is_generator()) {
if ((info->has_shared_info() && info->shared_info()->is_generator()) ||
(info->has_literal() && IsGeneratorFunction(info->literal()->kind()))) {
return false;
}

15
test/mjsunit/mjsunit.status
View File

@ -790,6 +790,7 @@
'es6/debug-liveedit-new-target-1': [FAIL],
'es6/debug-liveedit-new-target-2': [FAIL],
'es6/debug-liveedit-new-target-3': [FAIL],
'es6/generators-debug-liveedit': [FAIL],
# TODO(yangguo/rmcilroy,4690): Related to Debugger. Goes into a loop
# in function: Debug::FindSharedFunctionInfoInScript and times out.
@ -797,20 +798,6 @@
'regress/regress-1853': [SKIP],
'regress/regress-crbug-424142': [SKIP],
# TODO(rmcilroy,4681): Requires support for generators.
'es6/classes-subclass-builtins': [FAIL],
'es6/generators-runtime': [FAIL],
'es6/generators-parsing': [FAIL],
'es6/generators-iteration': [FAIL],
'es6/generators-states': [FAIL],
'es6/generators-relocation': [FAIL],
'es6/generators-debug-liveedit': [FAIL],
'es6/spread-call': [FAIL],
'es6/regress/regress-2691': [FAIL],
'harmony/destructuring-assignment': [FAIL],
'harmony/regress/regress-4482': [FAIL],
'harmony/reflect-construct': [FAIL],
# TODO(mythria, 4780): Related to type feedback for calls in interpreter.
'array-literal-feedback': [FAIL],
'regress/regress-4121': [FAIL],

43
test/test262/test262.status
View File

@ -415,47 +415,4 @@
'built-ins/ArrayBuffer/allocation-limit': [SKIP],
}], # asan == True or msan == True or tsan == True
['ignition == True', {
# TODO(rmcilroy,4681): Requires generator support.
'built-ins/GeneratorFunction/has-instance': [FAIL],
'built-ins/GeneratorFunction/instance-name': [FAIL],
'built-ins/GeneratorFunction/instance-restricted-properties': [FAIL],
'built-ins/GeneratorFunction/invoked-as-constructor-no-arguments': [FAIL],
'built-ins/GeneratorFunction/invoked-as-function-multiple-arguments': [FAIL],
'built-ins/GeneratorFunction/invoked-as-function-no-arguments': [FAIL],
'built-ins/GeneratorFunction/invoked-as-function-single-argument': [FAIL],
'built-ins/GeneratorPrototype/Symbol.toStringTag': [FAIL],
'built-ins/TypedArrays/object-arg-as-generator-iterable-returns': [FAIL],
'built-ins/TypedArrays/object-arg-iterating-throws': [FAIL],
'language/expressions/assignment/destructuring/array-elem-init-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-elem-nested-array-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-elem-nested-obj-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-elem-target-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-rest-nested-array-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-rest-nested-obj-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/array-rest-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/obj-id-init-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/obj-prop-elem-init-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/obj-prop-elem-target-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/obj-prop-nested-array-yield-expr': [FAIL],
'language/expressions/assignment/destructuring/obj-prop-nested-obj-yield-expr': [FAIL],
'language/expressions/object/method-definition/generator-prop-name-yield-expr': [FAIL],
'language/expressions/object/method-definition/name-prop-name-yield-expr': [FAIL],
'language/object-literal/concise-generator': [FAIL],
'language/statements/class/subclass/builtin-objects/GeneratorFunction/instance-length': [FAIL],
'language/statements/class/subclass/builtin-objects/GeneratorFunction/instance-name': [FAIL],
'language/statements/class/subclass/builtin-objects/GeneratorFunction/instance-prototype': [FAIL],
'language/statements/class/subclass/builtin-objects/GeneratorFunction/super-must-be-called': [FAIL],
'language/statements/class/subclass/builtin-objects/GeneratorFunction/regular-subclassing': [FAIL],
'language/statements/for-of/generator-next-error': [FAIL],
'language/statements/for-of/yield': [FAIL],
'language/statements/for-of/yield-from-catch': [FAIL],
'language/statements/for-of/yield-from-finally': [FAIL],
'language/statements/for-of/yield-from-try': [FAIL],
'language/statements/for-of/yield-star': [FAIL],
'language/statements/for-of/yield-star-from-catch': [FAIL],
'language/statements/for-of/yield-star-from-finally': [FAIL],
'language/statements/for-of/yield-star-from-try': [FAIL],
}], # ignition == True
]