AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[release-tools] Fix possible race condition in retrieval of latest rolled version

Browse Source 
R=machenbach@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/1186393007

Cr-Commit-Position: refs/heads/master@{#29137}
This commit is contained in:
hablich 2015-06-19 02:11:49 -07:00 committed by Commit bot
parent f6b71512ea
commit 5d2a85b245
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/release/auto_roll.py
View File

@ -48,6 +48,9 @@ class DetectLastRoll(Step):
max_age=self._options.max_age * DAY_IN_SECONDS)
assert revisions, "Didn't find any recent release."
# Update Chromium checkout before DEPS check to fix possible race-condition
self.GitPull(cwd=self._options.chromium)
# Interpret the DEPS file to retrieve the v8 revision.
# TODO(machenbach): This should be part or the roll-deps api of
# depot_tools.

2
tools/release/test_scripts.py
View File

@ -1112,6 +1112,7 @@ deps = {
Cmd("git describe --tags bad_tag", ""),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),
Cmd("git describe --tags abcd123455", "3.22.4"),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
@ -1135,6 +1136,7 @@ deps = {
Cmd("git describe --tags bad_tag", ""),
Cmd("git describe --tags hash_234", "3.22.4"),
Cmd("git describe --tags hash_123", "3.22.3"),
Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),
Cmd("git describe --tags abcd123455", "3.22.3.1"),
Cmd("git describe --tags hash_234", "3.22.4"),
])