AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap, runtime] Set upper limit on the size of fast fixed arrays that

Browse Source 
are created using new Array(N) and setLength(N).

Currently the limit is based on max old generation size, which
will break with the upcoming change that allows large heaps.

BUG=chromium:652721

Review-Url: https://codereview.chromium.org/2513923002
Cr-Commit-Position: refs/heads/master@{#41112}
This commit is contained in:
ulan 2016-11-18 06:31:09 -08:00 committed by Commit bot
parent f7723ff512
commit 5f06c1a1f3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/objects-inl.h
View File

@ -8131,11 +8131,13 @@ void JSArray::set_length(Smi* length) {
bool JSArray::SetLengthWouldNormalize(Heap* heap, uint32_t new_length) {
// This constant is somewhat arbitrary. Any large enough value would work.
const uint32_t kMaxFastArrayLength = 32 * 1024 * 1024;
// If the new array won't fit in a some non-trivial fraction of the max old
// space size, then force it to go dictionary mode.
uint32_t max_fast_array_size =
uint32_t heap_based_upper_bound =
static_cast<uint32_t>((heap->MaxOldGenerationSize() / kDoubleSize) / 4);
return new_length >= max_fast_array_size;
return new_length >= Min(kMaxFastArrayLength, heap_based_upper_bound);
}