AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools] include missing dep for v8_debug_helper

Browse Source 
This fixes a build break in certain configurations. v8_debug_helper
depends on generate_bytecode_builtins_list via the following headers:

In file included from gen/v8/tools/debug_helper/heap-constants-gen.cc:5:
In file included from ../../v8\src/common/ptr-compr-inl.h:10:
In file included from ../../v8\src/execution/isolate.h:19:
In file included from ../../v8\src/builtins/builtins.h:9:

Change-Id: I38e5d851afc6ce52716d3e5e64ae9219df396bd4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078768
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Auto-Submit: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66517}
This commit is contained in:
Seth Brenith 2020-02-28 10:27:42 -08:00 committed by Commit Bot
parent 84279bfcca
commit 5f5bcace28
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/debug_helper/BUILD.gn
View File

@ -32,15 +32,11 @@ action("run_mkgrokdump") {
testonly = true
visibility = [ ":*" ]
deps = [
"../../test/mkgrokdump:mkgrokdump($v8_generator_toolchain)",
]
deps = [ "../../test/mkgrokdump:mkgrokdump($v8_generator_toolchain)" ]
script = "../run.py"
outputs = [
"$target_gen_dir/v8heapconst.py",
]
outputs = [ "$target_gen_dir/v8heapconst.py" ]
args = [
"./" + rebase_path(
@ -56,13 +52,9 @@ action("run_mkgrokdump") {
action("gen_heap_constants") {
testonly = true
visibility = [ ":*" ]
deps = [
":run_mkgrokdump",
]
deps = [ ":run_mkgrokdump" ]
script = "gen-heap-constants.py"
outputs = [
"$target_gen_dir/heap-constants-gen.cc",
]
outputs = [ "$target_gen_dir/heap-constants-gen.cc" ]
args = [
rebase_path(target_gen_dir, root_build_dir),
rebase_path("$target_gen_dir/heap-constants-gen.cc", root_build_dir),
@ -72,9 +64,7 @@ action("gen_heap_constants") {
v8_component("v8_debug_helper") {
testonly = true
public = [
"debug-helper.h",
]
public = [ "debug-helper.h" ]
sources = [
"$target_gen_dir/../../torque-generated/class-debug-readers-tq.cc",
@ -91,6 +81,7 @@ v8_component("v8_debug_helper") {
deps = [
":gen_heap_constants",
"../..:generate_bytecode_builtins_list",
"../..:run_torque",
"../..:v8_headers",
"../..:v8_libbase",