AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[ia32][x64] Enable CPU feature in Assembler if supported

Browse Source 
x64 already had logic to enable a lower CPU extension if a higher
level one was supported. Add this to ia32. And also add SSSE3->SSE3
logic.

Drive-by cleanup to remove an extra CpuFeatureScope.

Bug: v8:11154
Change-Id: I12e3aa990cc07149da213911c624468a39f4e1a3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212811
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77291}
This commit is contained in:
Ng Zhi An 2021-10-07 12:33:53 -07:00 committed by V8 LUCI CQ
parent fed33f904f
commit 61203cb9b7
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/codegen/ia32/assembler-ia32.cc
View File

@ -324,6 +324,15 @@ Assembler::Assembler(const AssemblerOptions& options,
std::unique_ptr<AssemblerBuffer> buffer)
: AssemblerBase(options, std::move(buffer)) {
reloc_info_writer.Reposition(buffer_start_ + buffer_->size(), pc_);
if (CpuFeatures::IsSupported(SSE4_2)) {
EnableCpuFeature(SSE4_1);
}
if (CpuFeatures::IsSupported(SSE4_1)) {
EnableCpuFeature(SSSE3);
}
if (CpuFeatures::IsSupported(SSSE3)) {
EnableCpuFeature(SSE3);
}
}
void Assembler::GetCode(Isolate* isolate, CodeDesc* desc,

1
src/codegen/shared-ia32-x64/macro-assembler-shared-ia32-x64.cc
View File

@ -1139,7 +1139,6 @@ void SharedTurboAssembler::S128Load8Splat(XMMRegister dst, Operand src,
vpshufb(dst, dst, scratch);
} else {
CpuFeatureScope ssse4_scope(this, SSE4_1);
CpuFeatureScope ssse3_scope(this, SSSE3);
pinsrb(dst, src, uint8_t{0});
xorps(scratch, scratch);
pshufb(dst, scratch);

3
src/codegen/x64/assembler-x64.cc
View File

@ -347,6 +347,9 @@ Assembler::Assembler(const AssemblerOptions& options,
if (CpuFeatures::IsSupported(SSE4_1)) {
EnableCpuFeature(SSSE3);
}
if (CpuFeatures::IsSupported(SSSE3)) {
EnableCpuFeature(SSE3);
}
#if defined(V8_OS_WIN_X64)
if (options.collect_win64_unwind_info) {