AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Move inspector protocol definitions to include/

Browse Source 
This does not delete the files in the old locations yet since we need
to fix up the references in Chrome and Node.js.

Bug: v8:9247
Change-Id: I75dd469e19b6d4249ed187dd6d095d306f1b6c45
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649355
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62258}
This commit is contained in:
Yang Guo 2019-06-11 15:11:16 +02:00 committed by Commit Bot
parent b9bc81d6cf
commit 632239011d
8 changed files with 1503 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gni/v8.gni
View File

@ -92,7 +92,7 @@ if (v8_enable_backtrace == "") {
# subdirectories. # subdirectories.
v8_path_prefix = get_path_info("../", "abspath") v8_path_prefix = get_path_info("../", "abspath")
v8_inspector_js_protocol = v8_path_prefix + "/src/inspector/js_protocol.pdl" v8_inspector_js_protocol = v8_path_prefix + "/include/js_protocol.pdl"
############################################################################### ###############################################################################
# Templates # Templates

3
include/APIDesign.md
View File

@ -67,3 +67,6 @@ which in turn guarantees long-term stability of the API.
# The V8 inspector # The V8 inspector
All debugging capabilities of V8 should be exposed via the inspector protocol. All debugging capabilities of V8 should be exposed via the inspector protocol.
The exception to this are profiling features exposed via v8-profiler.h.
Changes to the inspector protocol need to ensure backwards compatibility and
commitment to maintain.

2
include/OWNERS
View File

@ -11,5 +11,7 @@ per-file v8-inspector.h=kozyatinskiy@chromium.org
per-file v8-inspector-protocol.h=dgozman@chromium.org per-file v8-inspector-protocol.h=dgozman@chromium.org
per-file v8-inspector-protocol.h=pfeldman@chromium.org per-file v8-inspector-protocol.h=pfeldman@chromium.org
per-file v8-inspector-protocol.h=kozyatinskiy@chromium.org per-file v8-inspector-protocol.h=kozyatinskiy@chromium.org
per-file js_protocol.pdl=dgozman@chromium.org
per-file js_protocol.pdl=pfeldman@chromium.org
# COMPONENT: Blink>JavaScript>API # COMPONENT: Blink>JavaScript>API

0
src/inspector/js_protocol-1.2.json → include/js_protocol-1.2.json
View File

0
src/inspector/js_protocol-1.3.json → include/js_protocol-1.3.json
View File

1492
include/js_protocol.pdl Normal file
View File

File diff suppressed because it is too large Load Diff

10
src/inspector/BUILD.gn
View File

@ -32,7 +32,7 @@ action("protocol_compatibility") {
visibility = [ ":*" ] # Only targets in this file can depend on this. visibility = [ ":*" ] # Only targets in this file can depend on this.
script = "$_inspector_protocol/check_protocol_compatibility.py" script = "$_inspector_protocol/check_protocol_compatibility.py"
inputs = [ inputs = [
"js_protocol.pdl", v8_inspector_js_protocol,
] ]
_stamp = "$target_gen_dir/js_protocol.stamp" _stamp = "$target_gen_dir/js_protocol.stamp"
outputs = [ outputs = [
@ -41,7 +41,7 @@ action("protocol_compatibility") {
args = [ args = [
"--stamp", "--stamp",
rebase_path(_stamp, root_build_dir), rebase_path(_stamp, root_build_dir),
rebase_path("js_protocol.pdl", root_build_dir), rebase_path(v8_inspector_js_protocol, root_build_dir),
] ]
} }
@ -53,10 +53,10 @@ inspector_protocol_generate("protocol_generated_sources") {
inspector_protocol_dir = _inspector_protocol inspector_protocol_dir = _inspector_protocol
out_dir = target_gen_dir out_dir = target_gen_dir
config_file = "inspector_protocol_config.json" config_file = v8_path_prefix + "/src/inspector/inspector_protocol_config.json"
inputs = [ inputs = [
"js_protocol.pdl", v8_inspector_js_protocol,
"inspector_protocol_config.json", config_file,
] ]
outputs = _protocol_generated outputs = _protocol_generated
} }

6
src/inspector/OWNERS
View File

@ -5,12 +5,6 @@ kozyatinskiy@chromium.org
pfeldman@chromium.org pfeldman@chromium.org
yangguo@chromium.org yangguo@chromium.org
# Changes to remote debugging protocol require devtools review to
# ensure backwards compatibility and commitment to maintain.
per-file js_protocol.pdl=set noparent
per-file js_protocol.pdl=dgozman@chromium.org
per-file js_protocol.pdl=pfeldman@chromium.org
per-file PRESUBMIT.py=file://INFRA_OWNERS per-file PRESUBMIT.py=file://INFRA_OWNERS
# COMPONENT: Platform>DevTools>JavaScript # COMPONENT: Platform>DevTools>JavaScript