From 63ca293dcf23a997ebc7940ecf39af1df99c6a90 Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Wed, 17 Oct 2018 00:32:45 +0200 Subject: [PATCH] Remove PersistentContainerCallbackType::kWeak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From what I understand, it's been slated for removal for a long time, and more accutely, Clang recently started warning about it being shadowed by another kWeak enum: ../../v8/include/v8-profiler.h:369:5: warning: declaration shadows a variable in namespace 'v8' [-Wshadow] kWeak = 6 // A weak reference (ignored by the GC). ^ ../../v8/include/v8-util.h:29:3: note: previous declaration is here kWeak = kWeakWithParameter // For backwards compatibility. Deprecate. ^ Bug: chromium:895475 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I07de1418aea2d68ef5641ece4ab13f71b6d5ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1285189 Reviewed-by: Marja Hölttä Reviewed-by: Adam Klein Commit-Queue: Hans Wennborg Cr-Commit-Position: refs/heads/master@{#56743} --- include/v8-util.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/v8-util.h b/include/v8-util.h index 52bc0e311c..475026fe2c 100644 --- a/include/v8-util.h +++ b/include/v8-util.h @@ -25,8 +25,7 @@ enum PersistentContainerCallbackType { kNotWeak, // These correspond to v8::WeakCallbackType kWeakWithParameter, - kWeakWithInternalFields, - kWeak = kWeakWithParameter // For backwards compatibility. Deprecate. + kWeakWithInternalFields }; /**