AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Add --no-wasm-lazy-compilation to nooptimization

Browse Source 
With shipping lazy compilation, we lose the test coverage for eager
compilation. This is bad, because with PGO, eager compilation may have
a comeback. With this CL we enable eager compilation in the
nooptimization test variant. This variant seems to be the best fit, as
there are no conflicts with existing flags. The --liftoff flag is not a
problem, because Liftoff was anyways the default for eager compilation.

R=clemensb@chromium.org

Bug: v8:12852
Change-Id: I002ecb2a31ad2e2335a0469fdf5e3d5bda3b33bc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027004
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84294}
This commit is contained in:
Andreas Haas 2022-11-15 08:45:04 +01:00 committed by V8 LUCI CQ
parent bb717e6f29
commit 63fc14c68b
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/testrunner/local/variants.py
View File

@ -27,8 +27,14 @@ ALL_VARIANT_FLAGS = {
# https://chromium-review.googlesource.com/c/452620/ for more discussion.
# For WebAssembly, we test "Liftoff-only" in the nooptimization variant and
# "TurboFan-only" in the stress variant. The WebAssembly configuration is
# independent of JS optimizations, so we can combine those configs.
"nooptimization": [["--no-turbofan", "--liftoff", "--no-wasm-tier-up"]],
# independent of JS optimizations, so we can combine those configs. We
# disable lazy compilation to have one test variant that tests eager
# compilation. "Liftoff-only" and eager compilation is not a problem,
# because test functions do typically not get optimized to TurboFan anyways.
"nooptimization": [[
"--no-turbofan", "--liftoff", "--no-wasm-tier-up",
"--no-wasm-lazy-compilation"
]],
"slow_path": [["--force-slow-path"]],
"stress": [[
"--no-liftoff", "--stress-lazy-source-positions",