[cleanup] Remove some obsolete TODOs.
R=sigurds@chromium.org Bug: v8:7570 Change-Id: I3f077940117467be98fbb3c2a30684af8eaaf801 Reviewed-on: https://chromium-review.googlesource.com/1032432 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52837}
This commit is contained in:
parent
600033e65c
commit
649c25263b
@ -42,8 +42,7 @@ function Stringify(x, depth) {
|
||||
case "string":
|
||||
return "\"" + x.toString() + "\"";
|
||||
case "bigint":
|
||||
// TODO(neis): Use x.toString() once we have it.
|
||||
return String(x) + "n";
|
||||
return x.toString() + "n";
|
||||
case "object":
|
||||
if (IS_NULL(x)) return "null";
|
||||
if (x.constructor && x.constructor.name === "Array") {
|
||||
|
@ -6934,7 +6934,6 @@ Maybe<bool> JSReceiver::DefineOwnProperty(Isolate* isolate,
|
||||
return JSTypedArray::DefineOwnProperty(
|
||||
isolate, Handle<JSTypedArray>::cast(object), key, desc, should_throw);
|
||||
}
|
||||
// TODO(neis): Special case for JSModuleNamespace?
|
||||
|
||||
// OrdinaryDefineOwnProperty, by virtue of calling
|
||||
// DefineOwnPropertyIgnoreAttributes, can handle arguments
|
||||
|
@ -137,7 +137,6 @@ class PrototypeIterator {
|
||||
}
|
||||
|
||||
// Returns false iff a call to JSProxy::GetPrototype throws.
|
||||
// TODO(neis): This should probably replace Advance().
|
||||
V8_WARN_UNUSED_RESULT bool AdvanceFollowingProxies() {
|
||||
DCHECK(!(handle_.is_null() && object_->IsJSProxy()));
|
||||
if (!HasAccess()) {
|
||||
|
@ -2,8 +2,6 @@
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
// TODO(neis): Test with proxies.
|
||||
|
||||
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
|
Loading…
Reference in New Issue
Block a user