AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove some obsolete TODOs.

Browse Source 
R=sigurds@chromium.org

Bug: v8:7570
Change-Id: I3f077940117467be98fbb3c2a30684af8eaaf801
Reviewed-on: https://chromium-review.googlesource.com/1032432
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52837}
This commit is contained in:
Georg Neis 2018-04-27 11:39:37 +02:00 committed by Commit Bot
parent 600033e65c
commit 649c25263b
4 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/d8.js
View File

@ -42,8 +42,7 @@ function Stringify(x, depth) {
case "string": case "string":
return "\"" + x.toString() + "\""; return "\"" + x.toString() + "\"";
case "bigint": case "bigint":
// TODO(neis): Use x.toString() once we have it. return x.toString() + "n";
return String(x) + "n";
case "object": case "object":
if (IS_NULL(x)) return "null"; if (IS_NULL(x)) return "null";
if (x.constructor && x.constructor.name === "Array") { if (x.constructor && x.constructor.name === "Array") {

1
src/objects.cc
View File

@ -6934,7 +6934,6 @@ Maybe<bool> JSReceiver::DefineOwnProperty(Isolate* isolate,
return JSTypedArray::DefineOwnProperty( return JSTypedArray::DefineOwnProperty(
isolate, Handle<JSTypedArray>::cast(object), key, desc, should_throw); isolate, Handle<JSTypedArray>::cast(object), key, desc, should_throw);
} }
// TODO(neis): Special case for JSModuleNamespace?
// OrdinaryDefineOwnProperty, by virtue of calling // OrdinaryDefineOwnProperty, by virtue of calling
// DefineOwnPropertyIgnoreAttributes, can handle arguments // DefineOwnPropertyIgnoreAttributes, can handle arguments

1
src/prototype.h
View File

@ -137,7 +137,6 @@ class PrototypeIterator {
} }
// Returns false iff a call to JSProxy::GetPrototype throws. // Returns false iff a call to JSProxy::GetPrototype throws.
// TODO(neis): This should probably replace Advance().
V8_WARN_UNUSED_RESULT bool AdvanceFollowingProxies() { V8_WARN_UNUSED_RESULT bool AdvanceFollowingProxies() {
DCHECK(!(handle_.is_null() && object_->IsJSProxy())); DCHECK(!(handle_.is_null() && object_->IsJSProxy()));
if (!HasAccess()) { if (!HasAccess()) {

2
test/mjsunit/es6/reflect.js
View File

@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// TODO(neis): Test with proxies.
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////