AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[compiler] Move InternalizedString to kNeverSerialized"

Browse Source 
This reverts commit 04cdcd5a88.

Reason for revert: TSAN failures https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34180

Original change's description:
> [compiler] Move InternalizedString to kNeverSerialized
>
> Bug: v8:7790
> Change-Id: I8311b1f4b8239d0688a4b9b9057d6082942bbc00
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534471
> Reviewed-by: Georg Neis <neis@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#71159}

TBR=neis@chromium.org,solanes@chromium.org

Change-Id: Ib950d1c6603a80e6fadb61839559c38761aea650
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7790
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534294
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71161}
This commit is contained in:
Shu-yu Guo 2020-11-12 16:46:42 +00:00 committed by Commit Bot
parent 9e4cd2bcd3
commit 6507b97522
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/heap-refs.h
View File

@ -61,8 +61,6 @@ enum class OddballType : uint8_t {
/* Subtypes of FixedArray */ \
V(ObjectBoilerplateDescription) \
V(ScopeInfo) \
/* Subtypes of String */ \
V(InternalizedString) \
/* Subtypes of Name */ \
V(Symbol) \
/* Subtypes of HeapObject */ \
@ -94,6 +92,7 @@ enum class OddballType : uint8_t {
V(FixedArray) \
V(FixedDoubleArray) \
/* Subtypes of Name */ \
V(InternalizedString) \
V(String) \
/* Subtypes of JSReceiver */ \
V(JSObject) \

15
src/compiler/js-heap-broker.cc
View File

@ -870,10 +870,12 @@ StringData::StringData(JSHeapBroker* broker, ObjectData** storage,
class InternalizedStringData : public StringData {
public:
InternalizedStringData(JSHeapBroker* broker, ObjectData** storage,
Handle<InternalizedString> object)
: StringData(broker, storage, object) {
DCHECK(!FLAG_turbo_direct_heap_access);
}
Handle<InternalizedString> object);
uint32_t array_index() const { return array_index_; }
private:
uint32_t array_index_;
};
ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index,
@ -896,6 +898,11 @@ ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index,
return result;
}
InternalizedStringData::InternalizedStringData(
JSHeapBroker* broker, ObjectData** storage,
Handle<InternalizedString> object)
: StringData(broker, storage, object) {}
namespace {
bool IsFastLiteralHelper(Handle<JSObject> boilerplate, int max_depth,