AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[d8] Avoid recursive unhandled rejected Promise processing"

Browse Source 
This reverts commit 66e4c99c82.

Reason for revert: Causes TSAN data races:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/11350

Original change's description:
> [d8] Avoid recursive unhandled rejected Promise processing
> 
> Bug: chromium:1126309
> Change-Id: I9d9d33cd151ed8af5ee8af09b8957eae9df2dcb1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410059
> Commit-Queue: Toon Verwaest <verwaest@chromium.org>
> Auto-Submit: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69986}

TBR=cbruni@chromium.org,verwaest@chromium.org

Change-Id: I39e6e40ade8d0fd8d3260d41513e68b4763753fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1126309
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419034
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70009}
This commit is contained in:
Bill Budge 2020-09-18 18:11:40 +00:00 committed by Commit Bot
parent b6693635cf
commit 66f1bf7bc2
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/d8/d8.cc
View File

@ -3723,8 +3723,6 @@ void Shell::PostBlockingBackgroundTask(std::unique_ptr<Task> task) {
bool Shell::HandleUnhandledPromiseRejections(Isolate* isolate) {
if (options.ignore_unhandled_promises) return true;
// Disabling recursive rejected Promise handling.
options.ignore_unhandled_promises = true;
PerIsolateData* data = PerIsolateData::Get(isolate);
int count = data->HandleUnhandledPromiseRejections();
Shell::unhandled_promise_rejections_.store(

9
test/message/mjsunit/fail/assert-in-promise-fail-recursive.out
View File

@ -8,4 +8,11 @@ Error: WebAssembly.compile(): Argument 0 must be a buffer source
at console.log (<anonymous>)
at *%(basename)s:12:9
1 pending unhandled Promise rejection(s) detected.
*%(basename)s:9: Error: WebAssembly.compile(): Argument 0 must be a buffer source
WebAssembly.compile();
^
Error: WebAssembly.compile(): Argument 0 must be a buffer source
at TypeError.name (*%(basename)s:9:15)
at TypeError.toString (<anonymous>)
2 pending unhandled Promise rejection(s) detected.