AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

MIPS: Delegating yield does not re-box result objects.

Browse Source 
Port r15113 (9d28761)

Delegating yield (yield*) should just pass on the iterator results it
receives instead of re-boxing them.

TEST=mjsunit/harmony/generators-iteration
BUG=

Review URL: https://codereview.chromium.org/16855009
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
palfia@homejinni.com 2013-06-13 17:47:28 +00:00
parent 1b5835f69f
commit 674d594606
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/mips/full-codegen-mips.cc
View File

@ -2052,9 +2052,11 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
__ push(a0); // exception
__ jmp(&l_call);
// try { received = yield result.value }
// try { received = %yield result }
// Shuffle the received result above a try handler and yield it without
// re-boxing.
__ bind(&l_try);
EmitCreateIteratorResult(false); // pop and box to v0
__ pop(a0); // result
__ PushTryHandler(StackHandler::CATCH, expr->index());
const int handler_size = StackHandlerConstants::kSize;
__ push(a0); // result
@ -2085,18 +2087,10 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
CallIC(ic);
__ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
// val = result.value; if (!result.done) goto l_try;
// if (!result.done) goto l_try;
__ bind(&l_loop);
__ mov(a0, v0);
// result.value
__ push(a0); // save result
__ LoadRoot(a2, Heap::kvalue_stringRootIndex); // "value"
Handle<Code> value_ic = isolate()->builtins()->LoadIC_Initialize();
CallIC(value_ic); // result.value in a0
__ mov(a0, v0);
__ pop(a1); // result
__ push(a0); // result.value
__ mov(a0, a1); // result
__ LoadRoot(a2, Heap::kdone_stringRootIndex); // "done"
Handle<Code> done_ic = isolate()->builtins()->LoadIC_Initialize();
CallIC(done_ic); // result.done in v0
@ -2106,7 +2100,10 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
__ Branch(&l_try, eq, v0, Operand(zero_reg));
// result.value
__ pop(v0); // result.value
__ pop(a0); // result
__ LoadRoot(a2, Heap::kvalue_stringRootIndex); // "value"
Handle<Code> value_ic = isolate()->builtins()->LoadIC_Initialize();
CallIC(value_ic); // result.value in v0
context()->DropAndPlug(2, v0); // drop iter and g
break;
}