From 67d543ec313df5a222b4d45a449a3a8641cd8a76 Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Tue, 7 Nov 2017 13:27:22 +0100 Subject: [PATCH] [test] Fix sanitizer options for OOM and leak detection Bug: chromium:726584 Change-Id: I49daa3e7de4f792db9908885ab94a87661950a4e Reviewed-on: https://chromium-review.googlesource.com/732654 Commit-Queue: Michael Achenbach Reviewed-by: Sergiy Byelozyorov Cr-Commit-Position: refs/heads/master@{#49186} --- test/mjsunit/mjsunit.status | 3 +++ tools/testrunner/base_runner.py | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index ace9f8e784..fc9882ead8 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -374,6 +374,9 @@ # Flaky on ASAN builds: https://bugs.chromium.org/p/v8/issues/detail?id=6305 'regress/regress-430201': [SKIP], 'regress/regress-430201b': [SKIP], + + # Stack overflow on windows. + 'es8/regress/regress-624300': [PASS, ['system == windows', SKIP]], }], # 'asan == True' ############################################################################## diff --git a/tools/testrunner/base_runner.py b/tools/testrunner/base_runner.py index 6699bf2d7c..51819e2c76 100644 --- a/tools/testrunner/base_runner.py +++ b/tools/testrunner/base_runner.py @@ -336,10 +336,16 @@ class BaseTestRunner(object): symbolizer_option = self._get_external_symbolizer_option() if self.build_config.asan: - asan_options = [symbolizer_option, "allow_user_segv_handler=1"] + asan_options = [ + symbolizer_option, + 'allow_user_segv_handler=1', + 'allocator_may_return_null=1', + ] if not utils.GuessOS() in ['macos', 'windows']: # LSAN is not available on mac and windows. asan_options.append('detect_leaks=1') + else: + asan_options.append('detect_leaks=0') os.environ['ASAN_OPTIONS'] = ":".join(asan_options) if self.build_config.cfi_vptr: