AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values.

Browse Source 
port f4c079d450 (r30107).

This is the appendix of 458dfe3b943edb3238917edfe9e2dde326cd1adb which misses
one modified file.

original commit message:

    There's no need to have one InstanceType per SIMD primitive type (this
    will not scale long-term).  Also reduce the amount of code duplication
    and make it more robust wrt adding new SIMD types.

BUG=

Review URL: https://codereview.chromium.org/1304963003

Cr-Commit-Position: refs/heads/master@{#30288}
This commit is contained in:
chunyang.dai 2015-08-21 03:10:35 -07:00 committed by Commit bot
parent 7a21a70c4e
commit 682365d77f
1 changed files with 11 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
src/x87/lithium-codegen-x87.cc
View File

@ -2439,12 +2439,8 @@ void LCodeGen::DoBranch(LBranch* instr) {
if (expected.Contains(ToBooleanStub::SIMD_VALUE)) {
// SIMD value -> true.
Label not_simd;
__ CmpInstanceType(map, FIRST_SIMD_VALUE_TYPE);
__ j(less, &not_simd, Label::kNear);
__ CmpInstanceType(map, LAST_SIMD_VALUE_TYPE);
__ j(less_equal, instr->TrueLabel(chunk_));
__ bind(&not_simd);
__ CmpInstanceType(map, SIMD128_VALUE_TYPE);
__ j(equal, instr->TrueLabel(chunk_));
}
if (expected.Contains(ToBooleanStub::HEAP_NUMBER)) {
@ -6150,40 +6146,16 @@ Condition LCodeGen::EmitTypeofIs(LTypeofIsAndBranch* instr, Register input) {
1 << Map::kIsUndetectable);
final_branch_condition = zero;
} else if (String::Equals(type_name, factory()->float32x4_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, FLOAT32X4_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->int32x4_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, INT32X4_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->bool32x4_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, BOOL32X4_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->int16x8_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, INT16X8_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->bool16x8_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, BOOL16X8_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->int8x16_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, INT8X16_TYPE, input);
final_branch_condition = equal;
} else if (String::Equals(type_name, factory()->bool8x16_string())) {
__ JumpIfSmi(input, false_label, false_distance);
__ CmpObjectType(input, BOOL8X16_TYPE, input);
// clang-format off
#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
} else if (String::Equals(type_name, factory()->type##_string())) { \
__ JumpIfSmi(input, false_label, false_distance); \
__ cmp(FieldOperand(input, HeapObject::kMapOffset), \
factory()->type##_map()); \
final_branch_condition = equal;
SIMD128_TYPES(SIMD128_TYPE)
#undef SIMD128_TYPE
// clang-format on
} else {
__ jmp(false_label, false_distance);