From 685e6078ffb1d865c6677c3b09f88c9cd923b5ed Mon Sep 17 00:00:00 2001 From: Piotr Sikora Date: Tue, 11 Jan 2022 01:02:54 -0800 Subject: [PATCH] [bazel] Use v8_enable_handle_zapping only in debug builds. This leads to a noticable performance improvements, and this flag is flipped to "is_debug" by the V8 Autoroller in release branches for the GN builds, so this change matches that behavior. Signed-off-by: Piotr Sikora Change-Id: I0a6d9798617939f822a6ce347ed2005b1597627a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380246 Reviewed-by: Victor Gomes Cr-Commit-Position: refs/heads/main@{#78561} --- .bazelrc | 1 + BUILD.bazel | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.bazelrc b/.bazelrc index ef69dda4a5..95bfad4a35 100644 --- a/.bazelrc +++ b/.bazelrc @@ -17,6 +17,7 @@ build:debug --compilation_mode=dbg build:debug --config=v8_enable_debugging_features build:debug --//:v8_enable_fast_mksnapshot build:debug --//:v8_enable_backtrace +build:debug --//:v8_enable_handle_zapping # v8_enable_debugging_features flags build:v8_enable_debugging_features --//:v8_enable_verify_heap diff --git a/BUILD.bazel b/BUILD.bazel index 65a1dbcfbe..3b68992cd0 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -104,10 +104,7 @@ v8_flag(name = "v8_enable_debug_code") v8_flag(name = "v8_enable_disassembler") -v8_flag( - name = "v8_enable_handle_zapping", - default = True, -) +v8_flag(name = "v8_enable_handle_zapping") v8_flag(name = "v8_enable_hugepage")