AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[builtins] Remove --stress-off-heap-code flag

Browse Source 
Embedded builtins are now based off the v8_enable_embedded_builtins
gn flag instead, which conditionally defines V8_EMBEDDED_BUILTINS.

Bug: v8:6666
Change-Id: I44d40d30fce3a3ed9bbf973d46c4990ba3fade40
Reviewed-on: https://chromium-review.googlesource.com/964361
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52092}
This commit is contained in:
jgruber 2018-03-21 09:12:51 +01:00 committed by Commit Bot
parent c5be7ab8e8
commit 68bdf6a75c
5 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
infra/testing/client.v8.pyl
View File

@ -36,14 +36,12 @@
'V8 Linux64 - fyi': [ 'V8 Linux64 - fyi': [
{'name': 'v8testing', 'variant': 'infra_staging', 'shards': 1}, {'name': 'v8testing', 'variant': 'infra_staging', 'shards': 1},
{'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 2}, {'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 2},
{'name': 'v8testing', 'variant': 'stress_off_heap_code', 'shards': 1},
{'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1},
{'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1},
], ],
'V8 Linux64 - debug - fyi': [ 'V8 Linux64 - debug - fyi': [
{'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2}, {'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2},
{'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 3}, {'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 3},
{'name': 'v8testing', 'variant': 'stress_off_heap_code', 'shards': 1},
{'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1},
{'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1},
], ],

1
infra/testing/tryserver.v8.pyl
View File

@ -11,7 +11,6 @@
'v8_linux64_fyi_rel_ng_triggered': [ 'v8_linux64_fyi_rel_ng_triggered': [
{'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2}, {'name': 'v8testing', 'variant': 'infra_staging', 'shards': 2},
{'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 2}, {'name': 'test262_variants', 'variant': 'infra_staging', 'shards': 2},
{'name': 'v8testing', 'variant': 'stress_off_heap_code', 'shards': 1},
{'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'mjsunit', 'variant': 'stress_sampling', 'shards': 1},
{'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1}, {'name': 'webkit', 'variant': 'stress_sampling', 'shards': 1},
], ],

7
src/flag-definitions.h
View File

@ -1025,13 +1025,6 @@ DEFINE_INT(fuzzer_random_seed, 0,
DEFINE_BOOL(trace_rail, false, "trace RAIL mode") DEFINE_BOOL(trace_rail, false, "trace RAIL mode")
DEFINE_BOOL(print_all_exceptions, false, DEFINE_BOOL(print_all_exceptions, false,
"print exception object and stack trace on each thrown exception") "print exception object and stack trace on each thrown exception")
#ifdef V8_EMBEDDED_BUILTINS
DEFINE_BOOL(stress_off_heap_code, false,
"Move code objects off-heap for testing.")
#else
FLAG_READONLY(BOOL, bool, stress_off_heap_code, false,
"Move code objects off-heap for testing.")
#endif
// runtime.cc // runtime.cc
DEFINE_BOOL(runtime_call_stats, false, "report runtime call counts and times") DEFINE_BOOL(runtime_call_stats, false, "report runtime call counts and times")

2
test/cctest/test-isolate-independent-builtins.cc
View File

@ -22,8 +22,6 @@ namespace test_isolate_independent_builtins {
#ifdef V8_EMBEDDED_BUILTINS #ifdef V8_EMBEDDED_BUILTINS
UNINITIALIZED_TEST(VerifyBuiltinsIsolateIndependence) { UNINITIALIZED_TEST(VerifyBuiltinsIsolateIndependence) {
FLAG_stress_off_heap_code = false; // Disable off-heap trampolines.
v8::Isolate::CreateParams create_params; v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator(); create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
v8::Isolate* v8_isolate = v8::Isolate::New(create_params); v8::Isolate* v8_isolate = v8::Isolate::New(create_params);

1
tools/testrunner/local/variants.py
View File

@ -19,7 +19,6 @@ ALL_VARIANT_FLAGS = {
"stress": [["--stress-opt", "--always-opt"]], "stress": [["--stress-opt", "--always-opt"]],
"stress_background_compile": [["--stress-background-compile"]], "stress_background_compile": [["--stress-background-compile"]],
"stress_incremental_marking": [["--stress-incremental-marking"]], "stress_incremental_marking": [["--stress-incremental-marking"]],
"stress_off_heap_code": [["--stress-off-heap-code"]],
# Trigger stress sampling allocation profiler with sample interval = 2^14 # Trigger stress sampling allocation profiler with sample interval = 2^14
"stress_sampling": [["--stress-sampling-allocation-profiler=16384"]], "stress_sampling": [["--stress-sampling-allocation-profiler=16384"]],
"trusted": [["--no-untrusted-code-mitigations"]], "trusted": [["--no-untrusted-code-mitigations"]],