AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[sandbox] Skip mkgrokdump test in non-sandbox mode

Browse Source 
When the sandbox is disabled, object layouts are now different as
ExternalPointerSlots are then 64-bit (raw pointers) instead of 32-bit
(ExternalPointerHandles).

Bug: v8:10391
Change-Id: Ia03d1ae9300fad96e40b77f0ed9544a1a118b74a
Cq-Include-Trybots: luci.v8.try.triggered:v8_linux64_no_sandbox_dbg_ng_triggered
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3884075
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83089}
This commit is contained in:
Samuel Groß 2022-09-08 16:48:03 +00:00 committed by V8 LUCI CQ
parent 95b02431bd
commit 68de20179c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/mkgrokdump/mkgrokdump.status
View File

@ -5,8 +5,8 @@
[
# Only test for default mode x64.
['variant != default or arch != x64 or lite_mode or not pointer_compression', {
['variant != default or arch != x64 or lite_mode or not pointer_compression or not sandbox', {
'*': [SKIP],
}], # variant != default or arch != x64 or lite_mode
}], # variant != default or arch != x64 or lite_mode or not pointer_compression or not sandbox
]