From 69138876cd0617204944455683d7eebe463f22b1 Mon Sep 17 00:00:00 2001 From: Ross McIlroy Date: Fri, 19 Oct 2018 14:34:53 +0100 Subject: [PATCH] [tools] Add lite_mode status file parameter. BUG=v8:8293 Change-Id: Ic58ac512d5f32d26756e21ca929dda79f133a40e Reviewed-on: https://chromium-review.googlesource.com/c/1290982 Reviewed-by: Michael Achenbach Commit-Queue: Ross McIlroy Cr-Commit-Position: refs/heads/master@{#56844} --- BUILD.gn | 1 + tools/testrunner/base_runner.py | 4 ++++ tools/unittests/run_tests_test.py | 3 ++- tools/unittests/testdata/testroot1/v8_build_config.json | 3 ++- tools/unittests/testdata/testroot2/v8_build_config.json | 3 ++- 5 files changed, 11 insertions(+), 3 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index ca3a4b26c5..c969d994c9 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1180,6 +1180,7 @@ action("v8_dump_build_config") { "v8_use_snapshot=$v8_use_snapshot", "v8_enable_embedded_builtins=$v8_enable_embedded_builtins", "v8_enable_verify_csa=$v8_enable_verify_csa", + "v8_enable_lite_mode=$v8_enable_lite_mode", ] if (v8_current_cpu == "mips" || v8_current_cpu == "mipsel" || diff --git a/tools/testrunner/base_runner.py b/tools/testrunner/base_runner.py index 5c71cb33ee..57739b3889 100644 --- a/tools/testrunner/base_runner.py +++ b/tools/testrunner/base_runner.py @@ -187,6 +187,7 @@ class BuildConfig(object): self.ubsan_vptr = build_config['is_ubsan_vptr'] self.embedded_builtins = build_config['v8_enable_embedded_builtins'] self.verify_csa = build_config['v8_enable_verify_csa'] + self.lite_mode = build_config['v8_enable_lite_mode'] # Export only for MIPS target if self.arch in ['mips', 'mipsel', 'mips64', 'mips64el']: self.mips_arch_variant = build_config['mips_arch_variant'] @@ -219,6 +220,8 @@ class BuildConfig(object): detected_options.append('embedded_builtins') if self.verify_csa: detected_options.append('verify_csa') + if self.lite_mode: + detected_options.append('lite_mode') return '\n'.join(detected_options) @@ -662,6 +665,7 @@ class BaseTestRunner(object): "ubsan_vptr": self.build_config.ubsan_vptr, "embedded_builtins": self.build_config.embedded_builtins, "verify_csa": self.build_config.verify_csa, + "lite_mode": self.build_config.lite_mode, } def _create_test_config(self, options): diff --git a/tools/unittests/run_tests_test.py b/tools/unittests/run_tests_test.py index a91bb072f3..723de395b0 100755 --- a/tools/unittests/run_tests_test.py +++ b/tools/unittests/run_tests_test.py @@ -355,7 +355,8 @@ class SystemTest(unittest.TestCase): basedir, dcheck_always_on=True, is_asan=True, is_cfi=True, is_msan=True, is_tsan=True, is_ubsan_vptr=True, target_cpu='x86', v8_enable_i18n_support=False, v8_target_cpu='x86', - v8_use_snapshot=False, v8_enable_embedded_builtins=False, v8_enable_verify_csa=False) + v8_use_snapshot=False, v8_enable_embedded_builtins=False, + v8_enable_verify_csa=False, v8_enable_lite_mode=False) result = run_tests( basedir, '--mode=Release', diff --git a/tools/unittests/testdata/testroot1/v8_build_config.json b/tools/unittests/testdata/testroot1/v8_build_config.json index 3fad3216a7..247d5b1d9b 100644 --- a/tools/unittests/testdata/testroot1/v8_build_config.json +++ b/tools/unittests/testdata/testroot1/v8_build_config.json @@ -17,5 +17,6 @@ "v8_target_cpu": "x64", "v8_use_snapshot": true, "v8_enable_embedded_builtins": false, - "v8_enable_verify_csa": false + "v8_enable_verify_csa": false, + "v8_enable_lite_mode": false } diff --git a/tools/unittests/testdata/testroot2/v8_build_config.json b/tools/unittests/testdata/testroot2/v8_build_config.json index 3fad3216a7..247d5b1d9b 100644 --- a/tools/unittests/testdata/testroot2/v8_build_config.json +++ b/tools/unittests/testdata/testroot2/v8_build_config.json @@ -17,5 +17,6 @@ "v8_target_cpu": "x64", "v8_use_snapshot": true, "v8_enable_embedded_builtins": false, - "v8_enable_verify_csa": false + "v8_enable_verify_csa": false, + "v8_enable_lite_mode": false }