AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[liftoff] Fix check for offset before moving stack value

Browse Source 
With https://crrev.com/c/1925524 we are moving elements on the stack by
their offset, but this transfer recipe is still checking the indices of
src and dst, which is incorrect.

Bug: chromium:1027410
Change-Id: Id7c7523c097bd06f3d107cb4d9de1052fc082105
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930606
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65129}
This commit is contained in:
Ng Zhi An 2019-11-22 09:39:55 -08:00 committed by Commit Bot
parent ca16eb1d6b
commit 6987ee4537
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wasm/baseline/liftoff-assembler.cc
View File

@ -90,7 +90,7 @@ class StackTransferRecipe {
case VarState::kStack:
switch (src.loc()) {
case VarState::kStack:
if (src_index == dst_index) break;
if (src.offset() == dst.offset()) break;
asm_->MoveStackValue(dst.offset(), src.offset(), src.type());
break;
case VarState::kRegister: