[wasm-simd] Add JS-API errors for Simd, tests

Change-Id: Ie7bf807a51b2dd822b956a92d0051bfabcaf81eb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246528
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68353}

src/wasm/wasm-js.cc

@@ -1817,6 +1817,9 @@ void WebAssemblyGlobalGetValueCommon(
     case i::wasm::ValueType::kF64:
       return_value.Set(receiver->GetF64());
       break;
+    case i::wasm::ValueType::kS128:
+      thrower.TypeError("Can't get the value of s128 WebAssembly.Global");
+      break;
     case i::wasm::ValueType::kExternRef:
     case i::wasm::ValueType::kFuncRef:
     case i::wasm::ValueType::kExnRef:
@@ -1831,7 +1834,6 @@ void WebAssemblyGlobalGetValueCommon(
     case i::wasm::ValueType::kI16:
     case i::wasm::ValueType::kBottom:
     case i::wasm::ValueType::kStmt:
-    case i::wasm::ValueType::kS128:
       UNREACHABLE();
   }
 }
@@ -1896,6 +1898,9 @@ void WebAssemblyGlobalSetValue(
       receiver->SetF64(f64_value);
       break;
     }
+    case i::wasm::ValueType::kS128:
+      thrower.TypeError("Can't set the value of s128 WebAssembly.Global");
+      break;
     case i::wasm::ValueType::kExternRef:
     case i::wasm::ValueType::kExnRef: {
       receiver->SetExternRef(Utils::OpenHandle(*args[0]));
@@ -1918,7 +1923,6 @@ void WebAssemblyGlobalSetValue(
     case i::wasm::ValueType::kI16:
     case i::wasm::ValueType::kBottom:
     case i::wasm::ValueType::kStmt:
-    case i::wasm::ValueType::kS128:
       UNREACHABLE();
   }
 }

test/cctest/wasm/test-c-wasm-entry.cc

@@ -39,7 +39,6 @@ class CWasmEntryArgTester {
     std::vector<uint8_t> code{wasm_function_bytes};
     runner_.Build(code.data(), code.data() + code.size());
     wasm_code_ = runner_.builder().GetFunctionCode(0);
-    Handle<WasmInstanceObject> instance(runner_.builder().instance_object());
     c_wasm_entry_ = compiler::CompileCWasmEntry(isolate_, sig_);
   }
 

test/mjsunit/wasm/simd-errors.js

@@ -0,0 +1,65 @@
+// Copyright 2020 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --experimental-wasm-simd
+
+load("test/mjsunit/wasm/wasm-module-builder.js");
+
+(function TestS128InSignatureThrows() {
+  print(arguments.callee.name);
+  let builder = new WasmModuleBuilder();
+  builder.addFunction('foo', kSig_s_i)
+    .addBody([
+      kExprLocalGet, 0,
+      kSimdPrefix,
+      kExprI32x4Splat])
+    .exportFunc()
+  const instance = builder.instantiate();
+  assertThrows(() => instance.exports.foo(33), TypeError);
+})();
+
+(function TestS128ParamInSignatureThrows() {
+  print(arguments.callee.name);
+  let builder = new WasmModuleBuilder();
+  builder.addFunction('foo', kSig_i_s)
+      .addBody([
+          kExprLocalGet, 0,
+          kSimdPrefix,
+          kExprI32x4ExtractLane, 1])
+      .exportFunc();
+  const instance = builder.instantiate();
+  assertThrows(() => instance.exports.foo(10), TypeError);
+})();
+
+(function TestImportS128Return() {
+  print(arguments.callee.name);
+  let builder = new WasmModuleBuilder();
+  builder.addImport('', 'f', makeSig([], [kWasmS128]));
+  builder.addFunction('foo', kSig_v_v)
+      .addBody([kExprCallFunction, 0, kExprDrop])
+      .exportFunc();
+  const instance = builder.instantiate({'': {f: _ => 1}});
+  assertThrows(() => instance.exports.foo(), TypeError);
+})();
+
+(function TestS128ImportThrows() {
+  print(arguments.callee.name);
+  let builder = new WasmModuleBuilder();
+  let sig_index = builder.addType(kSig_i_i);
+  let sig_s128_index = builder.addType(kSig_i_s);
+  let index = builder.addImport('', 'func', sig_s128_index);
+  builder.addFunction('foo', sig_index)
+    .addBody([
+      kExprLocalGet, 0,
+      kSimdPrefix,
+      kExprI32x4Splat,
+      kExprCallFunction, index])
+    .exportFunc();
+  const instance = builder.instantiate({'': {func: _ => {}}});
+  assertThrows(() => instance.exports.foo(14), TypeError);
+})();
+
+(function TestS128GlobalConstructor() {
+  assertThrows(() => new WebAssembly.Global({value: 'i128'}), TypeError);
+})();

test/mjsunit/wasm/wasm-module-builder.js

@@ -162,6 +162,8 @@ let kSig_r_v = makeSig([], [kWasmExternRef]);
 let kSig_a_v = makeSig([], [kWasmAnyFunc]);
 let kSig_a_i = makeSig([kWasmI32], [kWasmAnyFunc]);
 let kSig_e_v = makeSig([], [kWasmExnRef]);
+let kSig_s_i = makeSig([kWasmI32], [kWasmS128]);
+let kSig_i_s = makeSig([kWasmS128], [kWasmI32]);
 
 function makeSig(params, results) {
   return {params: params, results: results};
@@ -473,6 +475,7 @@ let kExprI8x16Splat = 0x0f;
 let kExprI16x8Splat = 0x10;
 let kExprI32x4Splat = 0x11;
 let kExprF32x4Splat = 0x13;
+let kExprI32x4ExtractLane = 0x15;
 let kExprI8x16LtU = 0x26;
 let kExprI8x16LeU = 0x2a;
 let kExprI32x4Eq = 0x37;