From 6a4162500062712d9ba8dfd82e786921605fa50b Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Thu, 6 Sep 2018 12:00:46 +0000 Subject: [PATCH] Revert "[test] Increase coverage of d8_default test suites" This reverts commit 8ac91f6c6a7f0b3505e919c90e1e2611f3fe8be0. Reason for revert: Some actual failures on Mac and debugger: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/2914 Failing message tests need to be skipped for predictable testing: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20predictable/18967 Original change's description: > [test] Increase coverage of d8_default test suites > > NOTRY=true > > Bug: v8:7285,v8:8140 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 > Reviewed-on: https://chromium-review.googlesource.com/1208496 > Commit-Queue: Michael Achenbach > Reviewed-by: Ross McIlroy > Reviewed-by: Sergiy Byelozyorov > Cr-Commit-Position: refs/heads/master@{#55682} TBR=rmcilroy@chromium.org,machenbach@chromium.org,sergiyb@chromium.org Change-Id: I701abe28317028acbf65769674f15517020d3496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7285, v8:8140 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1209347 Reviewed-by: Michael Achenbach Commit-Queue: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#55683} --- test/intl/intl.status | 8 -------- test/message/message.status | 6 ------ tools/testrunner/base_runner.py | 9 +++++---- 3 files changed, 5 insertions(+), 18 deletions(-) diff --git a/test/intl/intl.status b/test/intl/intl.status index c04d962ce8..57a29add3f 100644 --- a/test/intl/intl.status +++ b/test/intl/intl.status @@ -43,12 +43,4 @@ 'relative-time-format/default-locale-pt-BR': [SKIP], }], # system == windows' -['system == android', { - # Android's ICU data file does not have the Chinese/Japanese dictionary - # required for the test to pass. - 'break-iterator/zh-break': [FAIL], - # Unable to change locale on Android: - 'relative-time-format/default-locale-fr-CA': [FAIL], - 'relative-time-format/default-locale-pt-BR': [FAIL], -}], # 'system == android' ] diff --git a/test/message/message.status b/test/message/message.status index d106f51e27..6aba054251 100644 --- a/test/message/message.status +++ b/test/message/message.status @@ -43,10 +43,4 @@ 'wasm-trace-memory-liftoff': [SKIP], }], # arch != x64 and arch != ia32 -['variant == code_serializer', { - # TODO(yangguo): Code serializer output is incompatible with all message - # tests. - '*': [SKIP], -}], # variant == code_serializer - ] diff --git a/tools/testrunner/base_runner.py b/tools/testrunner/base_runner.py index 778e904d9c..481cc10134 100644 --- a/tools/testrunner/base_runner.py +++ b/tools/testrunner/base_runner.py @@ -73,12 +73,13 @@ TEST_MAP = { ], # This needs to stay in sync with test/d8_default.isolate. "d8_default": [ - "debugger", + # TODO(machenbach): uncomment after infra side lands. + #"debugger", "mjsunit", "webkit", - "message", - "preparser", - "intl", + #"message", + #"preparser", + #"intl", ], # This needs to stay in sync with test/optimize_for_size.isolate. "optimize_for_size": [