AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Fix a few more places where we don't check for termination"

Browse Source 
This reverts commit 8b283d0c7e.

Reason for revert: This test fails in stress mode: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20verify%20csa/31485/overview

Original change's description:
> Fix a few more places where we don't check for termination
>
> Bug: chromium:1376663, chromium:1393272
> Change-Id: Ie6ee25fb87f9959166b1696e36f07218d2959098
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4105981
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#84835}

Bug: chromium:1376663, chromium:1393272
Change-Id: Iaa9b1370a9e581dd8cb06b83855acaa9a22652c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4106370
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#84836}
This commit is contained in:
Leszek Swirski 2022-12-14 13:06:42 +00:00 committed by V8 LUCI CQ
parent 8b283d0c7e
commit 6a52ff1d84
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/d8/d8.cc
View File

@ -1329,7 +1329,6 @@ void Shell::DoHostImportModuleDynamically(void* import_data) {
static_cast<DynamicImportData*>(import_data);
Isolate* isolate(import_data_->isolate);
if (isolate->IsExecutionTerminating()) return;
HandleScope handle_scope(isolate);
Local<Context> realm = import_data_->context.Get(isolate);

1
test/inspector/isolate-data.cc
View File

@ -326,7 +326,6 @@ void InspectorIsolateData::MessageHandler(v8::Local<v8::Message> message,
// static
void InspectorIsolateData::PromiseRejectHandler(v8::PromiseRejectMessage data) {
v8::Isolate* isolate = data.GetPromise()->GetIsolate();
if (isolate->IsExecutionTerminating()) return;
v8::Local<v8::Context> context = isolate->GetEnteredOrMicrotaskContext();
if (context.IsEmpty()) return;
v8::Local<v8::Promise> promise = data.GetPromise();

19
test/mjsunit/regress/regress-1376663.js
View File

@ -1,19 +0,0 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --turbofan
function __f_0() {
onmessage = function(e) {
import("./does_not_exist.js").then();
while(true) {
}
}
}
function __f_1() {
}
let sab = new SharedArrayBuffer();
let w1 = new Worker(__f_0, {type: 'function'});
w1.postMessage({sab: sab});
let w2 = new Worker(__f_1, {type: 'function'});