AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Cleanup] Integrate v8_nosnapshot into mksnapshot

Browse Source 
This CL integrates the "v8_nosnapshot" source set into the "mksnapshot"
binary. The "mksnapshot" binary is the last use-site after unconditionally
enabling snapshot and embedded builtins.

Bug: v8:8519
Change-Id: I8e737e10a3f7729e18ac71733b811bf399ebf330
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873685
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64494}
This commit is contained in:
Simon Zünd 2019-10-22 14:14:53 +02:00 committed by Commit Bot
parent 2205ab3a92
commit 6a55a37d3a
1 changed files with 3 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
BUILD.gn
View File

@ -1338,25 +1338,6 @@ source_set("v8_maybe_snapshot") {
}
}
v8_source_set("v8_nosnapshot") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [
":torque_generated_initializers",
]
public_deps = [
":v8_maybe_icu",
]
sources = [
"src/snapshot/embedded/embedded-empty.cc",
"src/snapshot/snapshot-empty.cc",
]
configs = [ ":internal_config" ]
}
if (!v8_use_external_startup_data) {
v8_source_set("v8_snapshot") {
# Only targets in this file and the top-level visibility target can
@ -3811,6 +3792,7 @@ if (current_toolchain == v8_snapshot_toolchain) {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
"src/snapshot/embedded/embedded-empty.cc",
"src/snapshot/embedded/embedded-file-writer.cc",
"src/snapshot/embedded/embedded-file-writer.h",
"src/snapshot/embedded/platform-embedded-file-writer-aix.cc",
@ -3824,6 +3806,7 @@ if (current_toolchain == v8_snapshot_toolchain) {
"src/snapshot/embedded/platform-embedded-file-writer-win.cc",
"src/snapshot/embedded/platform-embedded-file-writer-win.h",
"src/snapshot/mksnapshot.cc",
"src/snapshot/snapshot-empty.cc",
]
configs = [ ":internal_config" ]
@ -3834,7 +3817,7 @@ if (current_toolchain == v8_snapshot_toolchain) {
":v8_init",
":v8_libbase",
":v8_libplatform",
":v8_nosnapshot",
":v8_maybe_icu",
"//build/win:default_exe_manifest",
]
}