AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turboshaft] avoid assertion violation caused by unreachable code

Browse Source 
Fixed: chromium:1376861

Change-Id: Iec3101ab506b43c0dc4bead3742132c479301e26
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3990783
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83976}
This commit is contained in:
Tobias Tebbi 2022-10-28 11:19:57 +02:00 committed by V8 LUCI CQ
parent ba091da0b0
commit 6ab695c908
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/turboshaft/machine-optimization-reducer.h
View File

@ -1572,10 +1572,18 @@ class MachineOptimizationReducer : public Next {
}
private:
// Try to match a constant and add it to `offset`. Return `true` if
// successful.
bool TryAdjustOffset(int32_t* offset, const Operation& maybe_constant,
uint8_t element_scale) {
if (!maybe_constant.Is<ConstantOp>()) return false;
const ConstantOp& constant = maybe_constant.Cast<ConstantOp>();
if (constant.Representation() != WordRepresentation::PointerSized()) {
// This can only happen in unreachable code. Ideally, we identify this
// situation and use `Asm().Unreachable()`. However, this is difficult to
// do from within this helper, so we just don't perform the reduction.
return false;
}
int64_t diff = constant.signed_integral();
int32_t new_offset;
if (diff <= (std::numeric_limits<int32_t>::max() >> element_scale) &&