AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] Use 16bit for Opcode and align input count

Browse Source 
Bug: v8:7700
Change-Id: Id4294fdfad414b34606a1f15e97dbd5485b8e23a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804868
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82160}
This commit is contained in:
Victor Gomes 2022-08-03 11:01:17 +02:00 committed by V8 LUCI CQ
parent d195ce148b
commit 6d0d869546
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/maglev/maglev-ir.h
View File

@ -216,7 +216,7 @@ class CompactInterpreterFrameState;
// Define the opcode enum.
#define DEF_OPCODES(type) k##type,
enum class Opcode : uint8_t { NODE_BASE_LIST(DEF_OPCODES) };
enum class Opcode : uint16_t { NODE_BASE_LIST(DEF_OPCODES) };
#undef DEF_OPCODES
#define PLUS_ONE(type) +1
static constexpr int kOpcodeCount = NODE_BASE_LIST(PLUS_ONE);
@ -563,17 +563,20 @@ const T* ObjectPtrBeforeAddress(const void* address) {
class NodeBase : public ZoneObject {
private:
// Bitfield specification.
using OpcodeField = base::BitField64<Opcode, 0, 7>;
using OpcodeField = base::BitField64<Opcode, 0, 16>;
static_assert(OpcodeField::is_valid(kLastOpcode));
using OpPropertiesField =
OpcodeField::Next<OpProperties, OpProperties::kSize>;
using InputCountField = OpPropertiesField::Next<size_t, 17>;
using NumTemporariesNeededField = InputCountField::Next<uint8_t, 2>;
using NumTemporariesNeededField = OpPropertiesField::Next<uint8_t, 2>;
// Align input count to 32-bit.
using UnusedField = NumTemporariesNeededField::Next<uint8_t, 4>;
using InputCountField = UnusedField::Next<size_t, 17>;
static_assert(InputCountField::kShift == 32);
protected:
// Subclasses may use the remaining bitfield bits.
template <class T, int size>
using NextBitField = NumTemporariesNeededField::Next<T, size>;
using NextBitField = InputCountField::Next<T, size>;
template <class T>
static constexpr Opcode opcode_of = detail::opcode_of_helper<T>::value;