From 6d5f0d87726d7be6bae987f0409cecb9778696cb Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" Date: Wed, 27 Feb 2013 12:30:23 +0000 Subject: [PATCH] Avoid HEAP macro in spaces.cc This was another top cause for TLS access. BUG=v8:2487 Review URL: https://codereview.chromium.org/12340101 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/spaces.cc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/spaces.cc b/src/spaces.cc index f5f7d6af0e..ac1d187237 100644 --- a/src/spaces.cc +++ b/src/spaces.cc @@ -68,11 +68,11 @@ HeapObjectIterator::HeapObjectIterator(PagedSpace* space, HeapObjectIterator::HeapObjectIterator(Page* page, HeapObjectCallback size_func) { Space* owner = page->owner(); - ASSERT(owner == HEAP->old_pointer_space() || - owner == HEAP->old_data_space() || - owner == HEAP->map_space() || - owner == HEAP->cell_space() || - owner == HEAP->code_space()); + ASSERT(owner == page->heap()->old_pointer_space() || + owner == page->heap()->old_data_space() || + owner == page->heap()->map_space() || + owner == page->heap()->cell_space() || + owner == page->heap()->code_space()); Initialize(reinterpret_cast(owner), page->area_start(), page->area_end(), @@ -2004,7 +2004,7 @@ void FreeListNode::set_size(Heap* heap, int size_in_bytes) { FreeListNode* FreeListNode::next() { ASSERT(IsFreeListNode(this)); - if (map() == HEAP->raw_unchecked_free_space_map()) { + if (map() == GetHeap()->raw_unchecked_free_space_map()) { ASSERT(map() == NULL || Size() >= kNextOffset + kPointerSize); return reinterpret_cast( Memory::Address_at(address() + kNextOffset)); @@ -2017,7 +2017,7 @@ FreeListNode* FreeListNode::next() { FreeListNode** FreeListNode::next_address() { ASSERT(IsFreeListNode(this)); - if (map() == HEAP->raw_unchecked_free_space_map()) { + if (map() == GetHeap()->raw_unchecked_free_space_map()) { ASSERT(Size() >= kNextOffset + kPointerSize); return reinterpret_cast(address() + kNextOffset); } else { @@ -2031,7 +2031,7 @@ void FreeListNode::set_next(FreeListNode* next) { // While we are booting the VM the free space map will actually be null. So // we have to make sure that we don't try to use it for anything at that // stage. - if (map() == HEAP->raw_unchecked_free_space_map()) { + if (map() == GetHeap()->raw_unchecked_free_space_map()) { ASSERT(map() == NULL || Size() >= kNextOffset + kPointerSize); Memory::Address_at(address() + kNextOffset) = reinterpret_cast
(next); @@ -2242,7 +2242,7 @@ FreeListNode* FreeList::FindNodeFor(int size_in_bytes, int* node_size) { break; } - ASSERT((*cur)->map() == HEAP->raw_unchecked_free_space_map()); + ASSERT((*cur)->map() == heap_->raw_unchecked_free_space_map()); FreeSpace* cur_as_free_space = reinterpret_cast(*cur); int size = cur_as_free_space->Size(); if (size >= size_in_bytes) { @@ -2378,7 +2378,7 @@ intptr_t FreeListCategory::SumFreeList() { intptr_t sum = 0; FreeListNode* cur = top_; while (cur != NULL) { - ASSERT(cur->map() == HEAP->raw_unchecked_free_space_map()); + ASSERT(cur->map() == cur->GetHeap()->raw_unchecked_free_space_map()); FreeSpace* cur_as_free_space = reinterpret_cast(cur); sum += cur_as_free_space->Size(); cur = cur->next();