From 6e376b6c5b573ea755578eda681fb7eda5758cb3 Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Wed, 15 Mar 2017 09:53:43 +0100 Subject: [PATCH] [test] Mark slow tests Mark slow tests discovered by manual audit of reported durations. Slow tests will run first, which will lead to higher test runner throughput. Also some tests have flaky timeouts occasionally. BUG=chromium:601468 Change-Id: If9aeb5422e79ff25b867b01c50386a5fdebeb494 Reviewed-on: https://chromium-review.googlesource.com/455736 Reviewed-by: Michael Starzinger Commit-Queue: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#43819} --- test/cctest/cctest.status | 3 +-- test/debugger/debugger.status | 6 ++++-- test/mjsunit/mjsunit.status | 14 ++++++++++---- test/test262/test262.status | 7 +++++++ 4 files changed, 22 insertions(+), 8 deletions(-) diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 44b8bf27c4..a2b94eca06 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -72,8 +72,7 @@ 'test-ast-types/*': [PASS, NO_VARIANTS], # This tests API threading, no point in running several variants. - # They are also slow in debug mode. - 'test-api/Threading*': [PASS, NO_VARIANTS, ['mode == debug', SLOW]], + 'test-api/Threading*': [PASS, SLOW, NO_VARIANTS], # BUG(2999). The cpu profiler tests are notoriously flaky. 'test-cpu-profiler/CpuProfileDeepStack': [SKIP], diff --git a/test/debugger/debugger.status b/test/debugger/debugger.status index 774e663e8b..2c2d95c22d 100644 --- a/test/debugger/debugger.status +++ b/test/debugger/debugger.status @@ -21,11 +21,13 @@ # parameter value 'debug/es6/debug-scope-default-param-with-eval': [FAIL], - # Slow test + # Slow tests 'debug/debug-scopes': [PASS, SLOW], + 'debug/debug-stepout-scope-part*': [PASS, SLOW], + 'debug/ignition/debug-step-prefix-bytecodes': [PASS, SLOW], # Too slow in debug mode and on slow platforms. - 'regress/regress-2318': [PASS, ['mode == debug or (arch != ia32 and arch != x64) or asan == True or msan == True', SKIP]], + 'regress/regress-2318': [PASS, SLOW, ['mode == debug or (arch != ia32 and arch != x64) or asan == True or msan == True', SKIP]], }], # ALWAYS ############################################################################## diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index 86681c1360..e7f024d8cc 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -84,7 +84,7 @@ # Issue 488: this test sometimes times out. # TODO(arm): This seems to flush out a bug on arm with simulator. - 'array-constructor': [PASS, TIMEOUT, ['arch == arm and simulator == True', SKIP]], + 'array-constructor': [PASS, SLOW, ['arch == arm and simulator == True', SKIP]], # Issue 4413: this test sometimes times out with TSAN because we trigger # the slow path in C++ with holey arrays in Function.prototype.apply. @@ -146,11 +146,18 @@ # Slow tests. 'copy-on-write-assert': [PASS, SLOW], + 'es6/tail-call-megatest*': [PASS, SLOW, FAST_VARIANTS, ['tsan', SKIP]], + 'es6/typedarray-construct-offset-not-smi': [PASS, SLOW], + 'harmony/regexp-property-script-extensions': [PASS, SLOW], 'numops-fuzz-part*': [PASS, ['mode == debug', SLOW]], 'readonly': [PASS, SLOW], + 'regress/regress-1122': [PASS, SLOW], + 'regress/regress-605470': [PASS, SLOW], + 'regress/regress-655573': [PASS, SLOW], 'regress/regress-1200351': [PASS, SLOW], 'regress/regress-crbug-474297': [PASS, ['gc_stress == False', SKIP]], - 'es6/tail-call-megatest*': [PASS, SLOW, FAST_VARIANTS, ['tsan', SKIP]], + 'wasm/embenchen/*': [PASS, SLOW], + 'wasm/unreachable-validation': [PASS, SLOW], # case-insensitive unicode regexp relies on case mapping provided by ICU. 'es6/unicode-regexp-ignore-case': [PASS, ['no_i18n == True', FAIL]], @@ -299,7 +306,6 @@ # Slow tests. 'array-concat': [PASS, SLOW], - 'array-constructor': [PASS, SLOW], 'array-indexing': [PASS, SLOW], 'array-reduce': [PASS, SLOW], 'array-sort': [PASS, SLOW], @@ -312,8 +318,8 @@ 'json2': [PASS, SLOW], 'math-floor-of-div-nosudiv': [PASS, SLOW], 'math-floor-of-div': [PASS, SLOW], + 'messages': [PASS, SLOW], 'packed-elements': [PASS, SLOW], - 'regress/regress-1122': [PASS, SLOW], 'regress/regress-2185-2': [PASS, SLOW], 'regress/regress-2185': [PASS, SLOW], 'regress/regress-2790': [PASS, SLOW], diff --git a/test/test262/test262.status b/test/test262/test262.status index ecfdbb54d4..7624e70c0a 100644 --- a/test/test262/test262.status +++ b/test/test262/test262.status @@ -630,6 +630,13 @@ 'language/literals/regexp/S7.8.5_A2.4_T2': [SKIP], 'built-ins/Array/prototype/slice/S15.4.4.10_A3_T1': [SKIP], 'built-ins/Array/prototype/slice/S15.4.4.10_A3_T2': [SKIP], + + ############################ SLOW TESTS ############################# + + 'annexB/built-ins/RegExp/RegExp-leading-escape-BMP': [PASS, SLOW], + 'annexB/built-ins/RegExp/RegExp-trailing-escape-BMP': [PASS, SLOW], + 'language/comments/S7.4_A5': [PASS, SLOW], + 'language/comments/S7.4_A6': [PASS, SLOW], }], # ALWAYS ['no_i18n == True', {