From 6e47d31fca032ef070dcf18bbd1b10e039383710 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9otime=20Grohens?= Date: Mon, 18 Jun 2018 13:00:52 +0200 Subject: [PATCH] [torque] Fix Signature printing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The operator<< for Signature objects in Torque incorrectly counted the number of named parameters instead of the total number of parameters when displaying them. This would cause the displayed signature to be "()" when no parameters were named, instead of the actual signature. Change-Id: I32572da5f5a378b71749515d89429172129bbcb9 Reviewed-on: https://chromium-review.googlesource.com/1104172 Reviewed-by: Tobias Tebbi Commit-Queue: Théotime Grohens Cr-Commit-Position: refs/heads/master@{#53792} --- src/torque/types.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/torque/types.cc b/src/torque/types.cc index d372c12907..2f1e579576 100644 --- a/src/torque/types.cc +++ b/src/torque/types.cc @@ -150,7 +150,7 @@ std::string UnionType::GetGeneratedTNodeTypeName() const { std::ostream& operator<<(std::ostream& os, const Signature& sig) { os << "("; - for (size_t i = 0; i < sig.parameter_names.size(); ++i) { + for (size_t i = 0; i < sig.parameter_types.types.size(); ++i) { if (i > 0) os << ", "; if (!sig.parameter_names.empty()) os << sig.parameter_names[i] << ": "; os << sig.parameter_types.types[i];