AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] disable load-elimination overlapping fields check in release mode

Browse Source 
Bug: chromium:996097
Change-Id: I2d3bb6e1b844c1ffae0a5e44b1125593402fb7be
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806675
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63798}
This commit is contained in:
Tobias Tebbi 2019-09-16 14:34:55 +02:00 committed by Commit Bot
parent 633d8307cf
commit 702005af44
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/compiler/load-elimination.cc
View File

@ -662,16 +662,14 @@ LoadElimination::FieldInfo const* LoadElimination::AbstractState::LookupField(
if (!result.has_value()) {
result = info;
} else {
if (**result != *info) {
// We detected a partially overlapping access here.
// We currently don't seem to have such accesses, so this code path is
// unreachable, but if we eventually have them, it is safe to return
// nullptr and continue the analysis. But store-store elimination is
// currently unsafe for such overlapping accesses, so when we remove
// this UNREACHABLE(), we should double-check that store-store
// elimination can handle it too.
UNREACHABLE();
}
// We detected a partially overlapping access here.
// We currently don't seem to have such accesses, so this code path is
// unreachable, but if we eventually have them, it is safe to return
// nullptr and continue the analysis. But store-store elimination is
// currently unsafe for such overlapping accesses, so when we remove
// this check, we should double-check that store-store elimination can
// handle it too.
DCHECK_EQ(**result, *info);
}
}
return *result;