From 707ef5754556f775247eb1322552cdb2059bceaa Mon Sep 17 00:00:00 2001
From: Deepti Gandluri <gdeepti@chromium.org>
Date: Thu, 28 May 2020 01:27:17 +0000
Subject: [PATCH] Revert "[codegen] Reduce kScratchDoubleReg usage"

This reverts commit b9d2c22ad0a5aab7b69f51dc857b76ba51826c33.

Reason for revert: Reverting due to regressions in multiple JS
performance/memory benchmarks.

Original change's description:
> [codegen] Reduce kScratchDoubleReg usage
>
> Bug: v8:10506
> Change-Id: I3fccaf640e23b5fcc7722164e2437b247684f824
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207919
> Reviewed-by: Zhi An Ng <zhin@chromium.org>
> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#67909}

TBR=gdeepti@chromium.org,zhin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:10506
Change-Id: I9a1c960c577f0e0d42c817d03bc56895268a0718
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219339
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68031}
---
 src/codegen/x64/macro-assembler-x64.cc | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/codegen/x64/macro-assembler-x64.cc b/src/codegen/x64/macro-assembler-x64.cc
index f6136c210c..fabf70bb03 100644
--- a/src/codegen/x64/macro-assembler-x64.cc
+++ b/src/codegen/x64/macro-assembler-x64.cc
@@ -725,7 +725,7 @@ void TurboAssembler::Cvtsd2ss(XMMRegister dst, Operand src) {
 void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Register src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtlsi2sd(dst, dst, src);
+    vcvtlsi2sd(dst, kScratchDoubleReg, src);
   } else {
     xorpd(dst, dst);
     cvtlsi2sd(dst, src);
@@ -735,7 +735,7 @@ void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Register src) {
 void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Operand src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtlsi2sd(dst, dst, src);
+    vcvtlsi2sd(dst, kScratchDoubleReg, src);
   } else {
     xorpd(dst, dst);
     cvtlsi2sd(dst, src);
@@ -745,7 +745,7 @@ void TurboAssembler::Cvtlsi2sd(XMMRegister dst, Operand src) {
 void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Register src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtlsi2ss(dst, dst, src);
+    vcvtlsi2ss(dst, kScratchDoubleReg, src);
   } else {
     xorps(dst, dst);
     cvtlsi2ss(dst, src);
@@ -755,7 +755,7 @@ void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Register src) {
 void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Operand src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtlsi2ss(dst, dst, src);
+    vcvtlsi2ss(dst, kScratchDoubleReg, src);
   } else {
     xorps(dst, dst);
     cvtlsi2ss(dst, src);
@@ -765,7 +765,7 @@ void TurboAssembler::Cvtlsi2ss(XMMRegister dst, Operand src) {
 void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Register src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtqsi2ss(dst, dst, src);
+    vcvtqsi2ss(dst, kScratchDoubleReg, src);
   } else {
     xorps(dst, dst);
     cvtqsi2ss(dst, src);
@@ -775,7 +775,7 @@ void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Register src) {
 void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Operand src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtqsi2ss(dst, dst, src);
+    vcvtqsi2ss(dst, kScratchDoubleReg, src);
   } else {
     xorps(dst, dst);
     cvtqsi2ss(dst, src);
@@ -785,7 +785,7 @@ void TurboAssembler::Cvtqsi2ss(XMMRegister dst, Operand src) {
 void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Register src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtqsi2sd(dst, dst, src);
+    vcvtqsi2sd(dst, kScratchDoubleReg, src);
   } else {
     xorpd(dst, dst);
     cvtqsi2sd(dst, src);
@@ -795,7 +795,7 @@ void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Register src) {
 void TurboAssembler::Cvtqsi2sd(XMMRegister dst, Operand src) {
   if (CpuFeatures::IsSupported(AVX)) {
     CpuFeatureScope scope(this, AVX);
-    vcvtqsi2sd(dst, dst, src);
+    vcvtqsi2sd(dst, kScratchDoubleReg, src);
   } else {
     xorpd(dst, dst);
     cvtqsi2sd(dst, src);