From 71bf27628f7d420b45096a04c7eb536773dd65de Mon Sep 17 00:00:00 2001 From: Mythri A Date: Wed, 27 Mar 2019 15:37:54 +0000 Subject: [PATCH] [mjsunit] Fix elements-kind test to not call %NeverOptimizeFunction test/mjsunit/elements-kind.js calls %NeverOptimizeFunction followed by %OptimizeFunctionOnNextCall later. If NeverOptimize marker is set, the funciton would not be optimized even when requested through %OptimizeFunctionOnNextCall Change-Id: I37307fee7afd083953699026a82bbf12c85581ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533865 Commit-Queue: Mythri Alle Reviewed-by: Michael Stanton Cr-Commit-Position: refs/heads/master@{#60503} --- test/mjsunit/elements-kind.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/mjsunit/elements-kind.js b/test/mjsunit/elements-kind.js index f5e6e34813..5a2355ecf6 100644 --- a/test/mjsunit/elements-kind.js +++ b/test/mjsunit/elements-kind.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --allow-natives-syntax --expose-gc --nostress-opt --typed-array-max-size-in-heap=2048 +// Flags: --allow-natives-syntax --expose-gc --nostress-opt var elements_kind = { fast_smi_only : 'fast smi only elements', @@ -202,7 +202,6 @@ function construct_objects() { // Test crankshafted transition SMI->DOUBLE. %EnsureFeedbackVectorForFunction(convert_to_double); - %NeverOptimizeFunction(convert_to_double); function convert_to_double(array) { array[1] = 2.5; assertKind(elements_kind.fast_double, array); @@ -215,7 +214,6 @@ smis = construct_smis(); convert_to_double(smis); // Test crankshafted transitions SMI->FAST and DOUBLE->FAST. %EnsureFeedbackVectorForFunction(convert_to_fast); - %NeverOptimizeFunction(convert_to_fast); function convert_to_fast(array) { array[1] = "two"; assertKind(elements_kind.fast, array); @@ -233,7 +231,6 @@ convert_to_fast(doubles); // Test transition chain SMI->DOUBLE->FAST (crankshafted function will // transition to FAST directly). %EnsureFeedbackVectorForFunction(convert_mixed); -%NeverOptimizeFunction(convert_mixed); function convert_mixed(array, value, kind) { array[1] = value; assertKind(kind, array);