From 725a0a90765d9aa9a46cc94d62c4d2bbb7eeb692 Mon Sep 17 00:00:00 2001 From: Andreas Haas Date: Wed, 4 Sep 2019 10:12:22 +0000 Subject: [PATCH] Revert "[wasm] Stage wasm-bigint" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit bf78435b2c19cb2523a8d935a0a0f6c3b2af962f. Reason for revert: This CL is not what I wanted to land. I mixed up my local branches. Original change's description: > [wasm] Stage wasm-bigint > > The implementation on wasm-bigint has been done, as far as I can tell. > There are no spec tests yet, only an out-dated copy of the original > spec tests which don't pass anymore. Therefore I disabled all the tests > for now and created a tracking bug at https://crbug.com/v8/9673. > > R=​adamk@chromium.org > > Bug: v8:7741, v8:9673 > Change-Id: I015846cc6008ad266402b6835e634723a1a076da > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781050 > Commit-Queue: Andreas Haas > Reviewed-by: Adam Klein > Cr-Commit-Position: refs/heads/master@{#63541} TBR=adamk@chromium.org,ahaas@chromium.org Change-Id: I5e8a42ad01200c01446efe4ea50f8ae6fef2c174 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7741, v8:9673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784279 Reviewed-by: Andreas Haas Commit-Queue: Andreas Haas Cr-Commit-Position: refs/heads/master@{#63546} --- test/common/wasm/wasm-module-runner.cc | 6 ------ test/fuzzer/wasm-fuzzer-common.cc | 6 ------ 2 files changed, 12 deletions(-) diff --git a/test/common/wasm/wasm-module-runner.cc b/test/common/wasm/wasm-module-runner.cc index d2869509cc..8de7655914 100644 --- a/test/common/wasm/wasm-module-runner.cc +++ b/test/common/wasm/wasm-module-runner.cc @@ -101,12 +101,6 @@ bool InterpretWasmModuleForTesting(Isolate* isolate, case kWasmF64: arguments[i] = WasmValue(0.0); break; - case kWasmAnyRef: - case kWasmFuncRef: - case kWasmExnRef: - arguments[i] = - WasmValue(Handle::cast(isolate->factory()->null_value())); - break; default: UNREACHABLE(); } diff --git a/test/fuzzer/wasm-fuzzer-common.cc b/test/fuzzer/wasm-fuzzer-common.cc index 35e942b262..29bccd6be8 100644 --- a/test/fuzzer/wasm-fuzzer-common.cc +++ b/test/fuzzer/wasm-fuzzer-common.cc @@ -89,12 +89,6 @@ const char* ValueTypeToConstantName(ValueType type) { return "kWasmF32"; case kWasmF64: return "kWasmF64"; - case kWasmAnyRef: - return "kWasmAnyRef"; - case kWasmFuncRef: - return "kWasmFuncRef"; - case kWasmExnRef: - return "kWasmExnRef"; default: UNREACHABLE(); }