AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove temp_instance in LoadTableSegments

Browse Source 
The temp_instance is not used but had an enormous performance impact.
The instantiation time of the zengarden WebAssembly module improved now
from 12 seconds to less than a second.

R=clemensh@chromium.org
BUG=v8:6146

Change-Id: Ibac7809b3b6092032abd77ed94f639c09f62d816
Reviewed-on: https://chromium-review.googlesource.com/458918
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44114}
This commit is contained in:
Andreas Haas 2017-03-24 15:07:15 +01:00 committed by Commit Bot
parent 6c2215325e
commit 7273f7011a
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/wasm/wasm-module.cc
View File

@ -2235,11 +2235,6 @@ class InstantiationHelper {
// TODO(titzer): We compile JS->WASM wrappers for functions are // TODO(titzer): We compile JS->WASM wrappers for functions are
// not exported but are in an exported table. This should be done // not exported but are in an exported table. This should be done
// at module compile time and cached instead. // at module compile time and cached instead.
WasmInstance temp_instance(module_);
temp_instance.context = isolate_->native_context();
temp_instance.mem_size = 0;
temp_instance.mem_start = nullptr;
temp_instance.globals_start = nullptr;
Handle<Code> wrapper_code = Handle<Code> wrapper_code =
js_to_wasm_cache_.CloneOrCompileJSToWasmWrapper( js_to_wasm_cache_.CloneOrCompileJSToWasmWrapper(