AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[interpreter] Remove unused helper generators.

Browse Source 
BUG=v8:6116

Change-Id: I4e521d2fb3964e0d3615ef1deea6b3418fc77c50
Reviewed-on: https://chromium-review.googlesource.com/458400
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44051}
This commit is contained in:
Igor Sheludko 2017-03-22 17:57:04 +01:00 committed by Commit Bot
parent 4a5d1e2535
commit 72ccad7d5c
2 changed files with 2 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/code-stubs.h
View File

@ -338,15 +338,6 @@ class CodeStub BASE_EMBEDDED {
void GenerateAssembly(compiler::CodeAssemblerState* state) const override; \
DEFINE_CODE_STUB(NAME, SUPER)
#define DEFINE_TURBOFAN_UNARY_OP_CODE_STUB_WITH_FEEDBACK(NAME, SUPER) \
public: \
static compiler::Node* Generate( \
CodeStubAssembler* assembler, compiler::Node* value, \
compiler::Node* context, compiler::Node* feedback_vector, \
compiler::Node* slot_id); \
void GenerateAssembly(compiler::CodeAssemblerState* state) const override; \
DEFINE_CODE_STUB(NAME, SUPER)
#define DEFINE_HANDLER_CODE_STUB(NAME, SUPER) \
public: \
Handle<Code> GenerateCode() override; \

27
src/interpreter/interpreter-generator.cc
View File

@ -45,11 +45,11 @@ class InterpreterGenerator {
Node* slot,
Node* vector);
// Generates code to perform the binary operation via |Generator|.
// Generates code to perform the binary operation via |generator|.
void DoBinaryOpWithFeedback(InterpreterAssembler* assembler,
BinaryOpGenerator generator);
// Generates code to perform the comparison via |Generator| while gathering
// Generates code to perform the |compare_op| comparison while gathering
// type feedback.
void DoCompareOpWithFeedback(Token::Value compare_op,
InterpreterAssembler* assembler);
@ -59,16 +59,6 @@ class InterpreterGenerator {
void DoBitwiseBinaryOp(Token::Value bitwise_op,
InterpreterAssembler* assembler);
// Generates code to perform the binary operation via |Generator| using
// an immediate value rather the accumulator as the rhs operand.
template <class Generator>
void DoBinaryOpWithImmediate(InterpreterAssembler* assembler);
// Generates code to perform the unary operation via |Generator| while
// gatering type feedback.
template <class Generator>
void DoUnaryOpWithFeedback(InterpreterAssembler* assembler);
// Generates code to perform the comparison operation associated with
// |compare_op|.
void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler);
@ -1562,19 +1552,6 @@ Node* InterpreterGenerator::BuildUnaryOp(Callable callable,
return __ CallStub(callable.descriptor(), target, context, accumulator);
}
template <class Generator>
void InterpreterGenerator::DoUnaryOpWithFeedback(
InterpreterAssembler* assembler) {
Node* value = __ GetAccumulator();
Node* context = __ GetContext();
Node* slot_index = __ BytecodeOperandIdx(0);
Node* feedback_vector = __ LoadFeedbackVector();
Node* result = Generator::Generate(assembler, value, context, feedback_vector,
slot_index);
__ SetAccumulator(result);
__ Dispatch();
}
// ToName
//
// Convert the object referenced by the accumulator to a name.