AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Correct guard region allocation behavior

Browse Source 
Change-Id: I19106adfd5407cbef05142fde3b7eb00ecd8ff52
Reviewed-on: https://chromium-review.googlesource.com/1043256
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53007}
This commit is contained in:
Eric Holk 2018-05-03 15:58:33 -07:00 committed by Commit Bot
parent bb60967e36
commit 72f6a76dd1
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wasm/wasm-memory.cc
View File

@ -279,11 +279,15 @@ MaybeHandle<JSArrayBuffer> NewArrayBuffer(Isolate* isolate, size_t size,
memory = memory_tracker->GetEmptyBackingStore(
&allocation_base, &allocation_length, isolate->heap());
} else {
bool require_full_guard_regions = trap_handler::IsTrapHandlerEnabled();
#if V8_TARGET_ARCH_64_BIT
bool require_full_guard_regions = true;
#else
bool require_full_guard_regions = false;
#endif
memory = TryAllocateBackingStore(memory_tracker, isolate->heap(), size,
require_full_guard_regions,
&allocation_base, &allocation_length);
if (memory == nullptr && require_full_guard_regions) {
if (memory == nullptr && !trap_handler::IsTrapHandlerEnabled()) {
// If we failed to allocate with full guard regions, fall back on
// mini-guards.
require_full_guard_regions = false;