Use --opt instead of --crankshaft in tests.

1. Replaces --crankshaft with --opt in tests.
2. Also fixes presubmit to check for --opt flag when
assertOptimized is used.
3. Updates testrunner/local/variants.py and 
v8_foozie.py to use --opt flag.
This would mean, nooptimize variant means there are
no optimizations. Not even with %OptimizeFunctionOnNextCall.

Bug:v8:6325

Change-Id: I638e743d0773a6729c6b9749e2ca1e2537f12ce6
Reviewed-on: https://chromium-review.googlesource.com/490206
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44985}

test/benchmarks/testcfg.py

@@ -35,7 +35,7 @@ from testrunner.objects import testcase
 
 
 class BenchmarksVariantGenerator(testsuite.VariantGenerator):
-  # Both --nocrankshaft and --stressopt are very slow. Add TF but without
+  # Both --noopt and --stressopt are very slow. Add TF but without
   # always opt to match the way the benchmarks are run for performance
   # testing.
   def FilterVariantsByTest(self, testcase):

test/cctest/heap/test-heap.cc

@@ -3342,7 +3342,7 @@ TEST(ReleaseOverReservedPages) {
   if (FLAG_never_compact) return;
   i::FLAG_trace_gc = true;
   // The optimizer can allocate stuff, messing up the test.
-  i::FLAG_crankshaft = false;
+  i::FLAG_opt = false;
   i::FLAG_always_opt = false;
   // Parallel compaction increases fragmentation, depending on how existing
   // memory is distributed. Since this is non-deterministic because of
@@ -3944,7 +3944,7 @@ TEST(Regress169209) {
 
 TEST(Regress169928) {
   i::FLAG_allow_natives_syntax = true;
-  i::FLAG_crankshaft = false;
+  i::FLAG_opt = false;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   LocalContext env;
@@ -4266,7 +4266,7 @@ static int AllocationSitesCount(Heap* heap) {
 
 
 TEST(EnsureAllocationSiteDependentCodesProcessed) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt) return;
   i::FLAG_allow_natives_syntax = true;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
@@ -4337,7 +4337,7 @@ TEST(EnsureAllocationSiteDependentCodesProcessed) {
 
 
 TEST(CellsInOptimizedCodeAreWeak) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt) return;
   i::FLAG_allow_natives_syntax = true;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
@@ -4381,7 +4381,7 @@ TEST(CellsInOptimizedCodeAreWeak) {
 
 
 TEST(ObjectsInOptimizedCodeAreWeak) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt) return;
   i::FLAG_allow_natives_syntax = true;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
@@ -4422,7 +4422,7 @@ TEST(ObjectsInOptimizedCodeAreWeak) {
 }
 
 TEST(NewSpaceObjectsInOptimizedCode) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft || i::FLAG_turbo) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt || i::FLAG_turbo) return;
   i::FLAG_allow_natives_syntax = true;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
@@ -4483,7 +4483,7 @@ TEST(NewSpaceObjectsInOptimizedCode) {
 }
 
 TEST(NoWeakHashTableLeakWithIncrementalMarking) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt) return;
   if (!i::FLAG_incremental_marking) return;
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_compilation_cache = false;

test/cctest/test-api-interceptors.cc

@@ -4191,7 +4191,7 @@ THREADED_TEST(NamedPropertyHandlerGetterAttributes) {
 
 
 THREADED_TEST(Regress256330) {
-  if (!i::FLAG_crankshaft) return;
+  if (!i::FLAG_opt) return;
   i::FLAG_allow_natives_syntax = true;
   LocalContext context;
   v8::HandleScope scope(context->GetIsolate());

test/cctest/test-api.cc

@@ -14359,7 +14359,7 @@ void SetFunctionEntryHookTest::RunTest() {
       CHECK_EQ(2, CountInvocations(NULL, "bar"));
       CHECK_EQ(200, CountInvocations("bar", "foo"));
       CHECK_EQ(200, CountInvocations(NULL, "foo"));
-    } else if (i::FLAG_crankshaft) {
+    } else if (i::FLAG_opt) {
       // For ignition we don't see the actual functions being called, instead
       // we see the InterpreterEntryTrampoline at least 102 times
       // (100 unoptimized calls to foo, and 2 calls to bar).
@@ -22001,7 +22001,7 @@ void TestStubCache(bool primary) {
   } else {
     FLAG_test_secondary_stub_cache = true;
   }
-  FLAG_crankshaft = false;
+  FLAG_opt = false;
 
   v8::Isolate::CreateParams create_params;
   create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
@@ -22920,7 +22920,7 @@ TEST(AccessCheckInIC) {
   if (FLAG_ignition || FLAG_turbo) return;
 
   FLAG_native_code_counters = true;
-  FLAG_crankshaft = false;
+  FLAG_opt = false;
 
   v8::Isolate::CreateParams create_params;
   create_params.array_buffer_allocator = CcTest::array_buffer_allocator();

test/cctest/test-compiler.cc

@@ -289,7 +289,7 @@ TEST(GetScriptLineNumber) {
 
 
 TEST(FeedbackVectorPreservedAcrossRecompiles) {
-  if (i::FLAG_always_opt || !i::FLAG_crankshaft) return;
+  if (i::FLAG_always_opt || !i::FLAG_opt) return;
   i::FLAG_allow_natives_syntax = true;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft()) return;

test/cctest/test-cpu-profiler.cc

@@ -1033,7 +1033,7 @@ TEST(BoundFunctionCall) {
 
 // This tests checks distribution of the samples through the source lines.
 static void TickLines(bool optimize) {
-  if (!optimize) i::FLAG_crankshaft = false;
+  if (!optimize) i::FLAG_opt = false;
   CcTest::InitializeVM();
   LocalContext env;
   i::FLAG_allow_natives_syntax = true;

test/cctest/test-flags.cc

@@ -252,7 +252,7 @@ TEST(FlagsRemoveIncomplete) {
   // if the list of arguments ends unexpectedly.
   SetFlagsToDefault();
   int argc = 3;
-  const char* argv[] = {"", "--crankshaft", "--expose-natives-as"};
+  const char* argv[] = {"", "--opt", "--expose-natives-as"};
   CHECK_EQ(2, FlagList::SetFlagsFromCommandLine(&argc,
                                                 const_cast<char **>(argv),
                                                 true));

test/debugger/debug/debug-compile-optimized.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --crankshaft
+// Flags: --opt
 
 Debug = debug.Debug;
 

test/debugger/debug/debug-evaluate-nested-let.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --crankshaft
+// Flags: --opt
 
 Debug = debug.Debug
 

test/debugger/debug/debug-optimize.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 var Debug = debug.Debug;
 

test/debugger/debug/debug-stepin-property-function-call.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --nocrankshaft
+// Flags: --noopt
 Debug = debug.Debug
 
 var exception = null;

test/debugger/debug/es6/debug-blockscopes.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --noanalyze-environment-liveness --crankshaft
+// Flags: --noanalyze-environment-liveness --opt
 // The functions used for testing backtraces. They are at the top to make the
 // testing of source line/column easier.
 

test/debugger/debug/regress/regress-crbug-633999.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --crankshaft --no-turbo
+// Flags: --opt --no-turbo
 
 var Debug = debug.Debug
 var exception = null;

test/inspector/cpu-profiler/coverage.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --crankshaft
+// Flags: --allow-natives-syntax --no-always-opt --opt
 
 var source =
 `

test/mjsunit/allocation-site-info.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 var elements_kind = {
   fast_smi_only            :  'fast smi only elements',
@@ -136,7 +136,7 @@ assertKind(elements_kind.fast, obj);
 obj = fastliteralcase(get_standard_literal(), 3);
 assertKind(elements_kind.fast, obj);
 
-// Make sure this works in crankshafted code too.
+// Make sure this works in optimized code too.
   %OptimizeFunctionOnNextCall(get_standard_literal);
 get_standard_literal();
 obj = get_standard_literal();
@@ -347,7 +347,7 @@ instanceof_check(realmBArray);
 assertOptimized(instanceof_check);
 
 // Try to optimize again, but first clear all type feedback, and allow it
-// to be monomorphic on first call. Only after crankshafting do we introduce
+// to be monomorphic on first call. Only after optimizing do we introduce
 // realmBArray. This should deopt the method.
   %DeoptimizeFunction(instanceof_check);
   %ClearFunctionFeedback(instanceof_check);

test/mjsunit/array-constructor-feedback.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc
-// Flags: --no-always-opt --crankshaft
+// Flags: --no-always-opt --opt
 
 // Test element kind of objects.
 

test/mjsunit/array-feedback.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 var elements_kind = {
   fast_smi_only            :  'fast smi only elements',

test/mjsunit/array-literal-feedback.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 var elements_kind = {
   fast_smi_only            :  'fast smi only elements',

test/mjsunit/array-literal-transitions.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --expose-gc --ignition-osr --no-always-opt
-// Flags: --crankshaft
+// Flags: --opt
 
 // IC and Crankshaft support for smi-only elements in dynamic array literals.
 function get(foo) { return foo; }  // Used to generate dynamic values.

test/mjsunit/array-push5.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var v = 0;
 

test/mjsunit/array-shift4.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // Inlining shift with holey smi arrays shouldn't deopt just because it
 // encounters the hole on the copy step.

test/mjsunit/array-store-and-grow.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 // Verifies that the KeyedStoreIC correctly handles out-of-bounds stores
 // to an array that grow it by a single element. Test functions are

test/mjsunit/compiler/deopt-inlined-from-call.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var global = this;
 

test/mjsunit/compiler/deopt-numberoroddball-binop.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   function foo(x, y) { return x << y; }

test/mjsunit/compiler/deopt-string-outofbounds.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var s = "12345";
 

test/mjsunit/compiler/increment-typefeedback.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function f(x) {
   x++;

test/mjsunit/compiler/inlined-array-pop-opt.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   function foo(a) { return a.pop(); }

test/mjsunit/compiler/inlined-call.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var global = this;
 

test/mjsunit/compiler/integral32-add-sub.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   function foo(x) {

test/mjsunit/compiler/manual-concurrent-recompile.js

@@ -27,7 +27,7 @@
 
 // Flags: --allow-natives-syntax --expose-gc
 // Flags: --concurrent-recompilation --block-concurrent-recompilation
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 if (!%IsConcurrentRecompilationSupported()) {
   print("Concurrent recompilation is disabled. Skipping this test.");

test/mjsunit/compiler/opt-next-call-turbo.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --turbo-filter=*
+// Flags: --allow-natives-syntax --opt --turbo-filter=*
 
 function foo() {
   with ({ value:"fooed" }) { return value; }

test/mjsunit/compiler/opt-next-call.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function foo() {
   return "fooed";

test/mjsunit/compiler/optimized-float32array-length.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var a = new Float32Array(1);
 function len(a) { return a.length; }

test/mjsunit/compiler/optimized-float64array-length.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var a = new Float64Array(1);
 function len(a) { return a.length; }

test/mjsunit/compiler/optimized-int32array-length.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var a = new Int32Array(1);
 function len(a) { return a.length; }

test/mjsunit/compiler/optimized-uint32array-length.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var a = new Uint32Array(1);
 function len(a) { return a.length; }

test/mjsunit/compiler/regress-5320.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function OptimizeTruncatingBinaryOp(func) {
   func(42, -2);

test/mjsunit/compiler/regress-compare-negate.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turbo --crankshaft
+// Flags: --allow-natives-syntax --turbo --opt
 
 function CompareNegate(a,b) {
  a = a|0;

test/mjsunit/compiler/uint8-clamped-array.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   function foo(a, v) {

test/mjsunit/const-field-tracking.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var global = this;
 

test/mjsunit/constant-folding-2.js

@@ -27,7 +27,7 @@
 
 
 // Flags: --nodead-code-elimination --fold-constants
-// Flags: --allow-natives-syntax --nostress-opt --crankshaft
+// Flags: --allow-natives-syntax --nostress-opt --opt
 
 function test(f) {
   f();

test/mjsunit/deopt-minus-zero.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --expose-gc --crankshaft
+// Flags: --allow-natives-syntax --expose-gc --opt
 
 function mul (a, b) {
   return a * b;

test/mjsunit/deopt-recursive-eager-once.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --turbo --no-always-opt
+// Flags: --allow-natives-syntax --opt --turbo --no-always-opt
 
 function foo(i, deopt = false) {
     if (i == 0) {

test/mjsunit/deopt-recursive-lazy-once.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --turbo --no-always-opt
+// Flags: --allow-natives-syntax --opt --turbo --no-always-opt
 
 function foo(i, deopt = false) {
     if (i == 0) {

test/mjsunit/deopt-recursive-soft-once.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --turbo --no-always-opt
+// Flags: --allow-natives-syntax --opt --turbo --no-always-opt
 
 
 function foo(i, deopt = false, deoptobj = null) {

test/mjsunit/deopt-unlinked.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --turbo --no-always-opt
+// Flags: --allow-natives-syntax --opt --turbo --no-always-opt
 
 function foo() {}
 

test/mjsunit/deopt-with-fp-regs.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 deopt_trigger = 0;
 side_effect = 0;

test/mjsunit/deserialize-optimize-inner.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --cache=code --no-lazy --serialize-inner
-// Flags: --crankshaft
+// Flags: --opt
 
 function f(x, y) { return x + y; }
 

test/mjsunit/div-mul-minus-one.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function div(g) {
   return (g/-1) ^ 1

test/mjsunit/elements-transition-hoisting.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax
-// Flags: --nostress-opt --crankshaft
+// Flags: --nostress-opt --opt
 
 // Ensure that ElementsKind transitions in various situations are hoisted (or
 // not hoisted) correctly, don't change the semantics programs and don't trigger

test/mjsunit/ensure-growing-store-learns.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --noverify-heap --noenable-slow-asserts
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 // --noverify-heap and --noenable-slow-asserts are set because the test is too
 // slow with it on.

test/mjsunit/es6/array-iterator-turbo.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --turbo --turbo-escape --allow-natives-syntax --no-always-opt
-// Flags: --crankshaft --turbo-filter=*
+// Flags: --opt --turbo-filter=*
 
 "use strict";
 

test/mjsunit/es6/block-let-crankshaft-sloppy.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // Check that the following functions are optimizable.
 var functions = [ f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14,

test/mjsunit/es6/block-let-crankshaft.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 "use strict";
 

test/mjsunit/es6/block-scoping-sloppy.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 // Test functionality of block scopes.
 
 // Hoisting of var declarations.

test/mjsunit/es6/block-scoping.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 // Test functionality of block scopes.
 
 "use strict";

test/mjsunit/field-type-tracking.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --nostress-opt --track-field-types
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 (function() {
   var o = { text: "Hello World!" };

test/mjsunit/getters-on-elements.js

@@ -26,7 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --max-opt-count=100 --noalways-opt
-// Flags: --nocollect-maps --crankshaft
+// Flags: --nocollect-maps --opt
 
 // We specify max-opt-count because we opt/deopt the same function many
 // times.

test/mjsunit/harmony/do-expressions.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --harmony-do-expressions --allow-natives-syntax --no-always-opt
-// Flags: --crankshaft
+// Flags: --opt
 
 function returnValue(v) { return v; }
 function MyError() {}

test/mjsunit/keyed-load-hole-to-undefined.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax
-// Flags: --no-stress-opt --crankshaft --no-always-opt
+// Flags: --no-stress-opt --opt --no-always-opt
 
 // --nostress-opt is specified because the test corrupts the "pristine"
 // array prototype chain by storing an element, and this is tracked

test/mjsunit/keyed-load-with-string-key.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 
 var o = {

test/mjsunit/keyed-load-with-symbol-key.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var s = Symbol("foo");
 

test/mjsunit/math-floor-of-div-minus-zero.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --nouse-inlining --crankshaft
+// Flags: --allow-natives-syntax --nouse-inlining --opt
 
 // Test for negative zero that doesn't need bail out
 

test/mjsunit/mjsunit.js

@@ -134,7 +134,7 @@ var V8OptimizationStatus = {
   kInterpreted: 1 << 6
 };
 
-// Returns true if --no-crankshaft mode is on.
+// Returns true if --no-opt mode is on.
 var isNeverOptimize;
 
 // Returns true if --always-opt mode is on.
@@ -550,10 +550,10 @@ var failWithMessage;
   assertOptimized = function assertOptimized(fun, sync_opt, name_opt) {
     if (sync_opt === undefined) sync_opt = "";
     var opt_status = OptimizationStatus(fun, sync_opt);
-    // Tests that use assertOptimized() do not make sense if --no-crankshaft
-    // option is provided. Such tests must add --crankshaft to flags comment.
+    // Tests that use assertOptimized() do not make sense if --no-opt
+    // option is provided. Such tests must add --opt to flags comment.
     assertFalse((opt_status & V8OptimizationStatus.kNeverOptimize) !== 0,
-                "test does not make sense with --no-crankshaft");
+                "test does not make sense with --no-opt");
     assertTrue((opt_status & V8OptimizationStatus.kIsFunction) !== 0, name_opt);
     if ((opt_status & V8OptimizationStatus.kMaybeDeopted) !== 0) {
       // When --deopt-every-n-times flag is specified it's no longer guaranteed

test/mjsunit/mjsunit.status

@@ -394,7 +394,7 @@
   # Flaky with baseline?
   'regress/regress-2185-2': [SKIP],
 
-  # Slow tests with --nocrankshaft.
+  # Slow tests with --noopt.
   'compiler/osr-one': [PASS, SLOW],
   'compiler/osr-two': [PASS, SLOW],
   'wasm/grow-memory': [PASS, SLOW],

test/mjsunit/modules-turbo1.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // MODULE
-// Flags: --allow-natives-syntax --turbo --crankshaft --turbo-filter=*
+// Flags: --allow-natives-syntax --turbo --opt --turbo-filter=*
 
 export let x = 0;
 function foo() { x++ };

test/mjsunit/never-optimize.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 function o1() {
 }

test/mjsunit/object-seal.js

@@ -28,7 +28,7 @@
 // Tests the Object.seal and Object.isSealed methods - ES 19.1.2.17 and
 // ES 19.1.2.13
 
-// Flags: --allow-natives-syntax --crankshaft --noalways-opt
+// Flags: --allow-natives-syntax --opt --noalways-opt
 
 // Test that we return obj if non-object is passed as argument
 var non_objects = new Array(undefined, null, 1, -1, 0, 42.43, Symbol("test"));

test/mjsunit/osr-elements-kind.js

@@ -116,7 +116,7 @@ function construct_doubles() {
   return a;
 }
 
-// Test transition chain SMI->DOUBLE->FAST (crankshafted function will
+// Test transition chain SMI->DOUBLE->FAST (optimized function will
 // transition to FAST directly).
 function convert_mixed(array, value, kind) {
   array[1] = value;

test/mjsunit/polymorph-arrays.js

@@ -83,7 +83,7 @@ function testPolymorphicLoads() {
   load = make_polymorphic_load_function();
   assertEquals(undefined, load(sparse_object_array, new Object()));
 
-  // Try with crankshaft.
+  // Try with optimizing compiler.
   load = make_polymorphic_load_function();
   %OptimizeFunctionOnNextCall(load);
   assertEquals(1, load(object_array, 1));

test/mjsunit/regress/regress-2132.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 function mul(x, y) {
   return (x * y) | 0;

test/mjsunit/regress/regress-2250.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // The original problem from the bug: In the example below SMI check for b
 // generated for inlining of equals invocation (marked with (*)) will be hoisted

test/mjsunit/regress/regress-2315.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var foo = (function() {
   return eval("(function bar() { return 1; })");

test/mjsunit/regress/regress-2339.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --expose-gc --crankshaft
+// Flags: --allow-natives-syntax --expose-gc --opt
 
 function simple() {
   return simple_two_args(0, undefined);

test/mjsunit/regress/regress-2451.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function f() {
   assertEquals(-1.0, Math.round(-1.5));

test/mjsunit/regress/regress-252797.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // The type feedback oracle had a bug when retrieving the map from an IC
 // starting with a negative lookup.

test/mjsunit/regress/regress-2618.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --use-osr --allow-natives-syntax --ignition-osr --crankshaft
+// Flags: --use-osr --allow-natives-syntax --ignition-osr --opt
 
 function f() {
   do {

test/mjsunit/regress/regress-3176.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function foo(a) {
   var sum = 0;

test/mjsunit/regress/regress-330046.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --use-osr --allow-natives-syntax --crankshaft
+// Flags: --use-osr --allow-natives-syntax --opt
 
 var o1 = {a : 10};
 var o2 = { };

test/mjsunit/regress/regress-347914.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --debug-code --gc-interval=201 --verify-heap --max-inlined-source-size=999999 --max-inlined-nodes=999999 --max-inlined-nodes-cumulative=999999
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 // Begin stripped down and modified version of mjsunit.js for easy minimization in CF.
 function MjsUnitAssertionError(message) {}

test/mjsunit/regress/regress-3650-3.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function foo(a) {
   for (var d in a) {

test/mjsunit/regress/regress-3709.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 function getobj() {
   return { bar : function() { return 0}};

test/mjsunit/regress/regress-385565.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var calls = 0;
 

test/mjsunit/regress/regress-410912.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --expose-gc --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --expose-gc --opt --no-always-opt
 
 var assertDoesNotThrow;
 var assertInstanceof;

test/mjsunit/regress/regress-4380.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function bar(a) {
   var x = a[0];

test/mjsunit/regress/regress-475705.js

@@ -5,7 +5,7 @@
 // Crankshaft changes the stack usage and messes up the binary search for the
 // stack depth that causes a stack overflow.  The issue only arises without
 // regexp optimization, which can happen on pages that create a lot of regexps.
-// Flags: --nocrankshaft --noregexp-optimization
+// Flags: --noopt --noregexp-optimization
 
 // Should not crash with a stack overflow in the regexp compiler, even when the
 // JS has used most of the stack.

test/mjsunit/regress/regress-5404.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function foo(a, b) {
   return a + "0123456789012";

test/mjsunit/regress/regress-5790.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 function foo(a) {
   "use strict";

test/mjsunit/regress/regress-5802.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   function eq(a, b) { return a == b; }

test/mjsunit/regress/regress-618608.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --validate-asm --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --validate-asm --allow-natives-syntax --opt --no-always-opt
 
 // /v8/test/mjsunit/regress/regress-crbug-431602.js
 // /v8/test/mjsunit/lazy-load.js

test/mjsunit/regress/regress-conditional-position.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --nocrankshaft
+// Flags: --noopt
 
 var functionToCatch;
 var lineNumber;

test/mjsunit/regress/regress-crbug-157019.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --nocrankshaft
+// Flags: --allow-natives-syntax --noopt
 
 function makeConstructor() {
   return function() {

test/mjsunit/regress/regress-crbug-157520.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --nocrankshaft
+// Flags: --noopt
 
 (function(){
   var f = function(arg) {

test/mjsunit/regress/regress-crbug-506443.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 assertSame = function assertSame() {
   if (found === expected) {

test/mjsunit/regress/regress-crbug-554831.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 (function() {
   var key = "s";

test/mjsunit/regress/regress-crbug-587068.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // The Crankshaft fast case for String.fromCharCode used to unconditionally
 // deoptimize on non int32 indices.

test/mjsunit/regress/regress-crbug-594183.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --crankshaft --no-always-opt
+// Flags: --allow-natives-syntax --opt --no-always-opt
 
 var global = {}
 

test/mjsunit/regress/regress-embedded-cons-string.js

@@ -28,7 +28,7 @@
 // Flags: --fold-constants --nodead-code-elimination
 // Flags: --expose-gc --allow-natives-syntax
 // Flags: --concurrent-recompilation --block-concurrent-recompilation
-// Flags: --crankshaft --no-always-opt
+// Flags: --opt --no-always-opt
 
 if (!%IsConcurrentRecompilationSupported()) {
   print("Concurrent recompilation is disabled. Skipping this test.");

test/mjsunit/regress/regress-map-invalidation-2.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 var c = { x: 2, y: 1 };
 

test/mjsunit/regress/regress-param-local-type.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --crankshaft
+// Flags: --allow-natives-syntax --opt
 
 // Test that we do not confuse the first local and the first parameter
 // when gathering type information.