AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Pass v8_postmortem_support to gyp/gn bridge.

Browse Source 
Also change fetch_deps.py to no longer be a no-op and rename
Main function for importing from other scripts.

R=machenbach@chromium.org

Bug: v8:6105
Change-Id: I067a212827316248f60e97ff27e9bb2dc20addfd
Reviewed-on: https://chromium-review.googlesource.com/860007
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50522}
This commit is contained in:
Yang Guo 2018-01-12 09:57:41 +01:00 committed by Commit Bot
parent 1f2fd64e11
commit 73ba170a75
2 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/v8.gyp
View File

@ -2619,6 +2619,7 @@
'v8_use_snapshot=<(v8_use_snapshot)',
'v8_optimized_debug=<(v8_optimized_debug)',
'v8_enable_disassembler=<(v8_enable_disassembler)',
'v8_postmortem_support=<(v8_postmortem_support)',
],
},
],

29
tools/node/fetch_deps.py
View File

@ -60,7 +60,14 @@ def EnsureGit(v8_path):
cwd=v8_path)
return True
def FetchDeps(v8_path, depot_tools):
def FetchDeps(v8_path):
# Verify path.
v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path)
# Check out depot_tools if necessary.
depot_tools = node_common.EnsureDepotTools(v8_path, True)
temporary_git = EnsureGit(v8_path)
try:
print "Fetching dependencies."
@ -76,20 +83,10 @@ def FetchDeps(v8_path, depot_tools):
finally:
if temporary_git:
node_common.UninitGit(v8_path)
def Main(v8_path):
# Verify paths.
v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path)
# Check out depot_tools if necessary.
depot_tools = node_common.EnsureDepotTools(v8_path, True)
# Fetch dependencies with gclient.
FetchDeps(v8_path, depot_tools)
# Clean up .gclient_entries file.
gclient_entries = os.normpath(os.path.join(v8_path, os.pardir, ".gclient_entries"))
if os.path.isfile(gclient_entries):
os.remove(gclient_entries)
if __name__ == "__main__":
if len(sys.argv) > 2 and sys.argv[2] == "force":
Main(sys.argv[1])
else:
print "Disabled for now unless 'force' is passed as second argument."
FetchDeps(sys.argv[1])