AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland "[x64][ia32] Activate Argument Count Consistency"

Browse Source 
This is a reland of b73557685b
Issue was fixed with https://crrev.com/c/3165058

Original change's description:
> [x64][ia32] Activate Argument Count Consistency
>
> Activate argument count consistency (receiver is always included in
> JS argument count) for x64 and ia32.
>
> Bug: v8:11112
> Change-Id: If60000b6566846c84f1042473d25d79bf5c86a9d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160198
> Auto-Submit: Patrick Thier <pthier@chromium.org>
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76838}

Bug: v8:11112
Change-Id: I7968525dce2d36f94b7c8d066b0729969c55c6fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171151
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76929}
This commit is contained in:
Patrick Thier 2021-09-15 09:42:15 +00:00 committed by V8 LUCI CQ
parent 790e1dfe62
commit 7511020bc8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -351,7 +351,8 @@ declare_args() {
# parameter count of function with JS linkage.
# TODO(v8:11112): Remove once all architectures support the flag and it is
# enabled unconditionally.
v8_include_receiver_in_argc = false
v8_include_receiver_in_argc =
v8_current_cpu == "x86" || v8_current_cpu == "x64"
}
# Derived defaults.