[cleanup] Mark wasm methods in subclasses with override.

Fixing clang-tidy warning.

Bug: v8:8015
Change-Id: If115a71b1c57eecdec7c57d3613a4f0bd90f2e66
Reviewed-on: https://chromium-review.googlesource.com/1226791
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Florian Sattler <sattlerf@google.com>
Cr-Commit-Position: refs/heads/master@{#55944}

src/wasm/baseline/liftoff-assembler.h

@@ -248,7 +248,7 @@ class LiftoffAssembler : public TurboAssembler {
   };
 
   LiftoffAssembler();
-  ~LiftoffAssembler();
+  ~LiftoffAssembler() override;
 
   LiftoffRegister PopToRegister(LiftoffRegList pinned = {});
 

src/wasm/function-body-decoder-impl.h

@@ -2451,7 +2451,7 @@ class WasmFullDecoder : public WasmDecoder<validate> {
     return true;
   }
 
-  virtual void onFirstError() {
+  void onFirstError() override {
     this->end_ = this->pc_;  // Terminate decoding loop.
     TRACE(" !%s\n", this->error_msg_.c_str());
     CALL_INTERFACE(OnFirstError);

src/wasm/module-compiler.cc

@@ -2296,7 +2296,7 @@ class AsyncCompileJob::CompileTask : public CancelableTask {
         job_(job),
         on_foreground_(on_foreground) {}
 
-  ~CompileTask() {
+  ~CompileTask() override {
     if (job_ != nullptr && on_foreground_) ResetPendingForegroundTask();
   }
 

src/wasm/module-decoder.cc

@@ -267,7 +267,7 @@ class ModuleDecoderImpl : public Decoder {
     }
   }
 
-  virtual void onFirstError() {
+  void onFirstError() override {
     pc_ = end_;  // On error, terminate section decoding loop.
   }
 

src/wasm/wasm-js.cc

@@ -212,7 +212,7 @@ class AsyncCompilationResolver : public i::wasm::CompilationResultResolver {
   AsyncCompilationResolver(i::Isolate* isolate, i::Handle<i::JSPromise> promise)
       : promise_(isolate->global_handles()->Create(*promise)) {}
 
-  ~AsyncCompilationResolver() {
+  ~AsyncCompilationResolver() override {
     i::GlobalHandles::Destroy(i::Handle<i::Object>::cast(promise_).location());
   }
 
@@ -248,7 +248,7 @@ class InstantiateModuleResultResolver
                                   i::Handle<i::JSPromise> promise)
       : promise_(isolate->global_handles()->Create(*promise)) {}
 
-  ~InstantiateModuleResultResolver() {
+  ~InstantiateModuleResultResolver() override {
     i::GlobalHandles::Destroy(i::Handle<i::Object>::cast(promise_).location());
   }
 
@@ -284,7 +284,7 @@ class InstantiateBytesResultResolver
         promise_(isolate_->global_handles()->Create(*promise)),
         module_(isolate_->global_handles()->Create(*module)) {}
 
-  ~InstantiateBytesResultResolver() {
+  ~InstantiateBytesResultResolver() override {
     i::GlobalHandles::Destroy(i::Handle<i::Object>::cast(promise_).location());
     i::GlobalHandles::Destroy(i::Handle<i::Object>::cast(module_).location());
   }
@@ -349,7 +349,7 @@ class AsyncInstantiateCompileResultResolver
                            : isolate_->global_handles()->Create(
                                  *maybe_imports.ToHandleChecked())) {}
 
-  ~AsyncInstantiateCompileResultResolver() {
+  ~AsyncInstantiateCompileResultResolver() override {
     i::GlobalHandles::Destroy(i::Handle<i::Object>::cast(promise_).location());
     if (!maybe_imports_.is_null()) {
       i::GlobalHandles::Destroy(

test/cctest/wasm/test-run-wasm-module.cc

@@ -284,7 +284,7 @@ class InterruptThread : public v8::base::Thread {
     WriteLittleEndianValue<int32_t>(ptr, interrupt_value_);
   }
 
-  virtual void Run() {
+  void Run() override {
     // Wait for the main thread to write the signal value.
     int32_t val = 0;
     do {

test/cctest/wasm/test-wasm-breakpoints.cc

@@ -72,7 +72,7 @@ class BreakHandler : public debug::DebugDelegate {
       : isolate_(isolate), expected_breaks_(expected_breaks) {
     v8::debug::SetDebugDelegate(reinterpret_cast<v8::Isolate*>(isolate_), this);
   }
-  ~BreakHandler() {
+  ~BreakHandler() override {
     // Check that all expected breakpoints have been hit.
     CHECK_EQ(count_, expected_breaks_.size());
     v8::debug::SetDebugDelegate(reinterpret_cast<v8::Isolate*>(isolate_),
@@ -181,7 +181,7 @@ class CollectValuesBreakHandler : public debug::DebugDelegate {
       : isolate_(isolate), expected_values_(expected_values) {
     v8::debug::SetDebugDelegate(reinterpret_cast<v8::Isolate*>(isolate_), this);
   }
-  ~CollectValuesBreakHandler() {
+  ~CollectValuesBreakHandler() override {
     v8::debug::SetDebugDelegate(reinterpret_cast<v8::Isolate*>(isolate_),
                                 nullptr);
   }

test/cctest/wasm/test-wasm-shared-engine.cc

@@ -117,7 +117,7 @@ class SharedEngineThread : public v8::base::Thread {
         engine_(engine),
         callback_(callback) {}
 
-  virtual void Run() {
+  void Run() override {
     SharedEngineIsolate isolate(engine_);
     callback_(isolate);
   }
@@ -146,10 +146,10 @@ class MockInstantiationResolver : public InstantiationResultResolver {
  public:
   explicit MockInstantiationResolver(Handle<Object>* out_instance)
       : out_instance_(out_instance) {}
-  virtual void OnInstantiationSucceeded(Handle<WasmInstanceObject> result) {
+  void OnInstantiationSucceeded(Handle<WasmInstanceObject> result) override {
     *out_instance_->location() = *result;
   }
-  virtual void OnInstantiationFailed(Handle<Object> error_reason) {
+  void OnInstantiationFailed(Handle<Object> error_reason) override {
     UNREACHABLE();
   }
 
@@ -162,13 +162,13 @@ class MockCompilationResolver : public CompilationResultResolver {
   MockCompilationResolver(SharedEngineIsolate& isolate,
                           Handle<Object>* out_instance)
       : isolate_(isolate), out_instance_(out_instance) {}
-  virtual void OnCompilationSucceeded(Handle<WasmModuleObject> result) {
+  void OnCompilationSucceeded(Handle<WasmModuleObject> result) override {
     isolate_.isolate()->wasm_engine()->AsyncInstantiate(
         isolate_.isolate(),
         base::make_unique<MockInstantiationResolver>(out_instance_), result,
         {});
   }
-  virtual void OnCompilationFailed(Handle<Object> error_reason) {
+  void OnCompilationFailed(Handle<Object> error_reason) override {
     UNREACHABLE();
   }
 

test/unittests/wasm/trap-handler-unittest.cc

@@ -23,7 +23,7 @@ void CrashOnPurpose() { *reinterpret_cast<volatile int*>(42); }
 // on failures.
 class SignalHandlerFallbackTest : public ::testing::Test {
  protected:
-  virtual void SetUp() {
+  void SetUp() override {
     struct sigaction action;
     action.sa_sigaction = SignalHandler;
     sigemptyset(&action.sa_mask);
@@ -32,7 +32,7 @@ class SignalHandlerFallbackTest : public ::testing::Test {
     sigaction(SIGBUS, &action, &old_bus_action_);
   }
 
-  virtual void TearDown() {
+  void TearDown() override {
     // be a good citizen and restore the old signal handler.
     sigaction(SIGSEGV, &old_segv_action_, nullptr);
     sigaction(SIGBUS, &old_bus_action_, nullptr);