AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix several stack-traces tests using assertUnreachable()

Browse Source 
These tests all called assertUnreachable within a try/catch block.

BUG=v8:5246

Review-Url: https://codereview.chromium.org/2209663003
Cr-Commit-Position: refs/heads/master@{#38323}
This commit is contained in:
jgruber 2016-08-04 00:19:15 -07:00 committed by Commit bot
parent 39a5998f04
commit 76193d4b6c
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/mjsunit/stack-traces.js
View File

@ -252,11 +252,14 @@ function testTraceNativeConversion(nativeFunc) {
function testOmittedBuiltin(throwing, omitted) {
var reached = false;
try {
throwing();
assertUnreachable(omitted);
reached = true;
} catch (e) {
assertTrue(e.stack.indexOf(omitted) < 0, omitted);
} finally {
assertFalse(reached);
}
}
@ -305,19 +308,18 @@ testOmittedBuiltin(function(){ [thrower, 2].sort(function (a,b) {
// Omitted because ADD from runtime.js is non-native builtin.
testOmittedBuiltin(function(){ thrower + 2; }, "ADD");
var reached = false;
var error = new Error();
error.toString = function() { assertUnreachable(); };
error.toString = function() { reached = true; };
error.stack;
assertFalse(reached);
reached = false;
error = new Error();
error.name = { toString: function() { assertUnreachable(); }};
error.message = { toString: function() { assertUnreachable(); }};
error.stack;
error = new Error();
Array.prototype.push = function(x) { assertUnreachable(); };
Array.prototype.join = function(x) { assertUnreachable(); };
Array.prototype.push = function(x) { reached = true; };
Array.prototype.join = function(x) { reached = true; };
error.stack;
assertFalse(reached);
var fired = false;
error = new Error({ toString: function() { fired = true; } });