AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Some cleanup in the Int64Lowering.

Browse Source 
I removed some stale comments and added a missing unit test.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/1772843003

Cr-Commit-Position: refs/heads/master@{#34586}
This commit is contained in:
ahaas 2016-03-08 06:11:50 -08:00 committed by Commit bot
parent 1b09697581
commit 7634d1aac1
3 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/compiler/int64-lowering.cc
View File

@ -333,7 +333,6 @@ void Int64Lowering::LowerNode(Node* node) {
ReplaceNode(node, replacement, nullptr);
break;
}
// kExprI64Ne:
// kExprI64LtS:
case IrOpcode::kInt64LessThan: {
LowerComparison(node, machine()->Int32LessThan(),
@ -366,14 +365,6 @@ void Int64Lowering::LowerNode(Node* node) {
// kExprI64Ctz:
// kExprI64Popcnt:
// kExprF32SConvertI64:
// kExprF32UConvertI64:
// kExprF64SConvertI64:
// kExprF64UConvertI64:
// kExprI64SConvertF32:
// kExprI64SConvertF64:
// kExprI64UConvertF32:
// kExprI64UConvertF64:
default: { DefaultLowering(node); }
}
}

2
src/compiler/wasm-compiler.cc
View File

@ -499,8 +499,6 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,
// kExprI64DivU:
// kExprI64RemS:
// kExprI64RemU:
// kExprI64And:
// kExprI64Ior:
case wasm::kExprI64Ior:
op = m->Word64Or();
break;

19
test/unittests/compiler/int64-lowering-unittest.cc
View File

@ -308,7 +308,6 @@ TEST_F(Int64LoweringTest, CallI64Parameter) {
// kExprI64DivU:
// kExprI64RemS:
// kExprI64RemU:
// kExprI64And:
// kExprI64Ior:
TEST_F(Int64LoweringTest, Int64Ior) {
LowerGraph(graph()->NewNode(machine()->Word64Or(), Int64Constant(value(0)),
@ -368,7 +367,6 @@ TEST_F(Int64LoweringTest, Int64Eq) {
start(), start()));
}
// kExprI64Ne:
// kExprI64LtS:
TEST_F(Int64LoweringTest, Int64LtS) {
TestComparison(machine()->Int64LessThan(), IsInt32LessThan, IsUint32LessThan);
@ -390,6 +388,13 @@ TEST_F(Int64LoweringTest, Int64LeU) {
}
// kExprI32ConvertI64:
TEST_F(Int64LoweringTest, I32ConvertI64) {
LowerGraph(graph()->NewNode(machine()->TruncateInt64ToInt32(),
Int64Constant(value(0))),
MachineRepresentation::kWord32);
EXPECT_THAT(graph()->end()->InputAt(1),
IsReturn(IsInt32Constant(low_word_value(0)), start(), start()));
}
// kExprI64SConvertI32:
// kExprI64UConvertI32:
@ -399,16 +404,6 @@ TEST_F(Int64LoweringTest, Int64LeU) {
// kExprI64Clz:
// kExprI64Ctz:
// kExprI64Popcnt:
// kExprF32SConvertI64:
// kExprF32UConvertI64:
// kExprF64SConvertI64:
// kExprF64UConvertI64:
// kExprI64SConvertF32:
// kExprI64SConvertF64:
// kExprI64UConvertF32:
// kExprI64UConvertF64:
} // namespace compiler
} // namespace internal
} // namespace v8